Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: refactor read mechanism #18030

Closed
wants to merge 2 commits into from
Closed

http2: refactor read mechanism #18030

wants to merge 2 commits into from

Commits on Jan 13, 2018

  1. src: introduce internal buffer slice constructor 

    Add a C++ variant of `Buffer.from(arrayBuffer, offset, length)`.
    @addaleax
    addaleax committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    406875e View commit details
    Browse the repository at this point in the history

  2. http2: refactor read mechanism 

    Refactor the read mechanism to completely avoid copying.

Instead of copying individual `DATA` frame contents into buffers,
create `ArrayBuffer` instances for all socket reads and emit
slices of those `ArrayBuffer`s to JS.
    @addaleax
    addaleax committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    d6fcbed View commit details
    Browse the repository at this point in the history