Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: un-mark Socket#write “removal” as notable change #18083

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Since the method is inherited from Writable, usage of the method
does not change at all after its removal as an explicit method.

Calling it out as notable might therefore be more confusing than
helpful.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Since the method is inherited from `Writable`, usage of the method
does not change at all after its removal as an explicit method.

Calling it out as notable might therefore be more confusing than
helpful.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 10, 2018
@addaleax
Copy link
Member Author

Landed in 6e3818f

@addaleax addaleax closed this Jan 10, 2018
@addaleax addaleax deleted the cl-9-socket-proto-write branch January 10, 2018 16:22
addaleax added a commit that referenced this pull request Jan 10, 2018
Since the method is inherited from `Writable`, usage of the method
does not change at all after its removal as an explicit method.

Calling it out as notable might therefore be more confusing than
helpful.

PR-URL: #18083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit that referenced this pull request Jan 10, 2018
Since the method is inherited from `Writable`, usage of the method
does not change at all after its removal as an explicit method.

Calling it out as notable might therefore be more confusing than
helpful.

PR-URL: #18083
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit to addaleax/nodejs.org that referenced this pull request Jan 10, 2018
Applied from nodejs/node#18083

---

    doc: un-mark Socket#write “removal” as notable change

    Since the method is inherited from `Writable`, usage of the method
    does not change at all after its removal as an explicit method.

    Calling it out as notable might therefore be more confusing than
    helpful.
addaleax added a commit to nodejs/nodejs.org that referenced this pull request Jan 10, 2018
Applied from nodejs/node#18083

---

    doc: un-mark Socket#write “removal” as notable change

    Since the method is inherited from `Writable`, usage of the method
    does not change at all after its removal as an explicit method.

    Calling it out as notable might therefore be more confusing than
    helpful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants