Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: decapitalize primitive types #18110

Closed
wants to merge 1 commit into from
Closed

doc: decapitalize primitive types #18110

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 11, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 11, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 11, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/82/

ChALkeR
ChALkeR approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I didn't find more cases.

vsemozhetbyt added a commit that referenced this pull request Jan 12, 2018
@vsemozhetbyt
doc: decapitalize primitive types
d955645 
PR-URL: #18110
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in d955645

@vsemozhetbyt vsemozhetbyt deleted the doc-decap-prim-types branch January 12, 2018 00:49
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@vsemozhetbyt @evanlucas
doc: decapitalize primitive types
afc30a5 
PR-URL: #18110
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@vsemozhetbyt @MylesBorins
doc: decapitalize primitive types
835573a 
PR-URL: #18110
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vsemozhetbyt @ChALkeR @jasnell @cjihrig @MylesBorins @nodejs-github-bot