Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky interval test #18140

Closed

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Jan 14, 2018

A test was recently introduced that consistently fails on OS X & a few other machines. This PR reliably fixes it.

CI: https://ci.nodejs.org/job/node-test-pull-request/12522/
Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1686/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@apapirovski apapirovski added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 14, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 14, 2018
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This version of the test fails on 9.3.0 and passes on master, which is exactly what we'd expect.

@Trott
Copy link
Member

Trott commented Jan 14, 2018

+1 to fast-tracking to unbreak CI

@apapirovski
Copy link
Member Author

Thanks everyone. Landed in 8d04323

@apapirovski apapirovski deleted the fix-flaky-interval-test branch January 14, 2018 17:30
apapirovski added a commit that referenced this pull request Jan 14, 2018
PR-URL: #18140
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@Trott
Copy link
Member

Trott commented Jan 15, 2018

Alas, still flaky. https://ci.nodejs.org/job/node-test-commit-linux-containered/1416/nodes=ubuntu1604_sharedlibs_debug_x64/console

03:37:24 not ok 2014 sequential/test-timers-set-interval-excludes-callback-duration
03:37:24   ---
03:37:24   duration_ms: 1.220
03:37:24   severity: fail
03:37:24   stack: |-
03:37:24     assert.js:45
03:37:24       throw new errors.AssertionError(obj);
03:37:24       ^
03:37:24     
03:37:24     AssertionError [ERR_ASSERTION]: false == true
03:37:24         at Timeout.setInterval [as _onTimeout] (/home/iojs/build/workspace/node-test-commit-linux-containered/nodes/ubuntu1604_sharedlibs_debug_x64/test/sequential/test-timers-set-interval-excludes-callback-duration.js:14:5)
03:37:24         at ontimeout (timers.js:455:11)
03:37:24         at tryOnTimeout (timers.js:304:5)
03:37:24         at Timer.listOnTimeout (timers.js:267:5)
03:37:24   ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants