Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks,test: Only use IPv6 in http test #18143

Closed
wants to merge 1 commit into from
Closed

async_hooks,test: Only use IPv6 in http test #18143

wants to merge 1 commit into from

Conversation

AndreasMadsen
Copy link
Member

If IPv6 is not supported on a machine, the IPv6 handle will first be
created, this will then fail and default to an IPv4 handle. This causes
the graph to change, as there now is an extra handle.

Fix: #18003 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

async_hooks

@AndreasMadsen
async_hooks,test: Only use IPv6 in http test
a061c80 
If IPv6 is not supported on a machine, the IPv6 handle will first be
created, this will then fail and default to an IPv4 handle. This causes
the graph to change, as there now is an extra handle.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jan 14, 2018
@AndreasMadsen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12524/

@AndreasMadsen AndreasMadsen added fast-track PRs that do not need to wait for 48 hours to land. dont-land-on-v4.x http Issues or PRs related to the http subsystem. labels Jan 14, 2018
@AndreasMadsen AndreasMadsen mentioned this pull request Jan 14, 2018
Closed
3 tasks
@AndreasMadsen
Copy link
Member Author

Test failure is unrelated:

sequential/test-timers-setInterval-excludes-callback-duration

assert.js:45
  throw new errors.AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: false == true
    at Timeout.setInterval [as _onTimeout] (/home/iojs/build/workspace/node-test-binary-arm/test/sequential/test-timers-setInterval-excludes-callback-duration.js:15:5)
    at ontimeout (timers.js:455:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:267:5)

@AndreasMadsen
Copy link
Member Author

/cc @Trott @jasnell

Trott
Trott approved these changes Jan 14, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 to fast-tracking.

@Trott
Copy link
Member

Trott commented Jan 14, 2018

Might another possibility (future enhancement, doesn't have to happen now or even ever) be to expect a different call graph in that condition rather than skipping the test?

@apapirovski
Copy link
Member

Landed in b12425d

apapirovski pushed a commit that referenced this pull request Jan 14, 2018
@AndreasMadsen @apapirovski
async_hooks,test: only use IPv6 in http test
b12425d 
If IPv6 is not supported on a machine, the IPv6 handle will first be
created, this will then fail and default to an IPv4 handle. This causes
the graph to change, as there now is an extra handle.

PR-URL: #18143
Fixes: #18003
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 16, 2018
Closed
Closed
gibfahn pushed a commit to gibfahn/node that referenced this pull request Jan 17, 2018
@AndreasMadsen @gibfahn
async_hooks,test: only use IPv6 in http test
cc7e20e 
If IPv6 is not supported on a machine, the IPv6 handle will first be
created, this will then fail and default to an IPv4 handle. This causes
the graph to change, as there now is an extra handle.

PR-URL: nodejs#18143
Backport-PR-URL: nodejs#18179
Fixes: nodejs#18003
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2018
@AndreasMadsen @MylesBorins
async_hooks,test: only use IPv6 in http test
0211175 
If IPv6 is not supported on a machine, the IPv6 handle will first be
created, this will then fail and default to an IPv4 handle. This causes
the graph to change, as there now is an extra handle.

Backport-PR-URL: #18179
PR-URL: #18143
Fixes: #18003
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 30, 2018
Closed
Closed
evanlucas pushed a commit that referenced this pull request Jan 31, 2018
@AndreasMadsen @evanlucas
async_hooks,test: only use IPv6 in http test
e9397d6 
If IPv6 is not supported on a machine, the IPv6 handle will first be
created, this will then fail and default to an IPv4 handle. This causes
the graph to change, as there now is an extra handle.

Backport-PR-URL: #18474
PR-URL: #18143
Fixes: #18003
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AndreasMadsen @Trott @apapirovski @jasnell @addaleax @BethGriggs @nodejs-github-bot