Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-async-wrap-getasyncid parallelizable #18245

Closed
wants to merge 1 commit into from
Closed

test: make test-async-wrap-getasyncid parallelizable #18245

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Previously this test cannot be run with the node-stress-single-test job because the tmp dir is not created before common.PIPE is listened. See https://ci.nodejs.org/job/node-stress-single-test/1712/nodes=alpine34-container-x64/console

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 19, 2018
@joyeecheung
Copy link
Member Author

stress test: https://ci.nodejs.org/job/node-stress-single-test/1720/ (expect to fail until #18241 lands, but should fail with the flake instead of EACCES)
CI: https://ci.nodejs.org/job/node-test-pull-request/12616/

@joyeecheung
Copy link
Member Author

(Ah, wait, the title is actually misleading, it should be "make test-async-wrap-getasyncid runnable by itself" but that's probably too long..

Trott
Trott approved these changes Jan 19, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Optional idea: Perhaps it makes sense to put it in the block with common.PIPE so they're a unit in case anyone ever refactors the file into multiple files or something like that?

@joyeecheung
Copy link
Member Author

The stress test is actually green. I tried it on my local alpine box and I think the flake cannot be reproduced by simply stressing this test...

@joyeecheung
Copy link
Member Author

Oh, I tried a different configuration and this time the flake shows up: https://ci.nodejs.org/job/node-stress-single-test/1721/nodes=alpine34-container-x64/

@joyeecheung
Copy link
Member Author

Went with @Trott 's suggestion and put the common.refersthTmpDir into the block.

CI: https://ci.nodejs.org/job/node-test-pull-request/12617/
stress test with RUN_TIMES=100: https://ci.nodejs.org/job/node-stress-single-test/1724
stress test with RUN_TIMES=100 and --repeat 1000 : https://ci.nodejs.org/job/node-stress-single-test/1723

@apapirovski
Copy link
Member

@nodejs/collaborators Does anyone oppose having this fast-tracked? I would like to land this relatively soon and then run the stress test against #18241

@apapirovski apapirovski added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 19, 2018
@Trott
Copy link
Member

Trott commented Jan 19, 2018

+1 to fast-tracking.

@apapirovski
Copy link
Member

Thanks everyone. Landed in bfe41fe

apapirovski pushed a commit that referenced this pull request Jan 19, 2018
@joyeecheung @apapirovski
test: make async-wrap-getasyncid parallelizable
bfe41fe 
PR-URL: #18245
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joyeecheung joyeecheung mentioned this pull request Jan 20, 2018
Closed
3 tasks
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@joyeecheung @evanlucas
test: make async-wrap-getasyncid parallelizable
7a7e130 
PR-URL: #18245
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@joyeecheung @evanlucas
test: make async-wrap-getasyncid parallelizable
761f26e 
PR-URL: #18245
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@joyeecheung @MylesBorins
test: make async-wrap-getasyncid parallelizable
74d86cc 
PR-URL: #18245
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@joyeecheung @MayaLekova
test: make async-wrap-getasyncid parallelizable
c7659ba 
PR-URL: nodejs#18245
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joyeecheung @apapirovski @Trott @addaleax @cjihrig @BridgeAR @MylesBorins @nodejs-github-bot