Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] doc: capitalize non-primitive types #18465

Closed
wants to merge 1 commit into from
Closed

[v9.x backport] doc: capitalize non-primitive types #18465

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Backport of #18111

@vsemozhetbyt
doc: capitalize non-primitive types
b324281 
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v9.x labels Jan 30, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Jan 30, 2018 •
edited
Loading

https://ci.nodejs.org/job/node-test-pull-request-lite/140/

@vsemozhetbyt vsemozhetbyt mentioned this pull request Jan 30, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
6b1a40e 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 6b1a40e

@vsemozhetbyt vsemozhetbyt deleted the backport-18111-to-v9.x branch February 20, 2018 22:35
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
be1d3b8 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
325dc27 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@vsemozhetbyt @MylesBorins
doc: capitalize non-primitive types
e84e9db 
Backport-PR-URL: #18465
PR-URL: #18111
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @MylesBorins @BridgeAR @nodejs-github-bot