Commits on Feb 9, 2018

1. async_hooks: deprecate unsafe emit{Before,After} …

   The emit{Before,After} APIs in AsyncResource are problematic.
   
   * emit{Before,After} are named to suggest that the only thing they do
     is emit the before and after hooks. However, they in fact, mutate
     the current execution context.
   * They must be properly nested. Failure to do so by user code leads
     to catastrophic (unrecoverable) exceptions. It is very easy for the
     users to forget that they must be using a try/finally block around
     the code that must be surrounded by these operations. Even the
     example provided in the official docs makes this mistake. Failing
     to use a finally can lead to a catastrophic crash if the callback
     ends up throwing.
   
   This change provides a safer `runInAsyncScope` API as an alternative
   and deprecates emit{Before,After}.
   
   PR-URL: nodejs#18513
   Reviewed-By: James M Snell <jasnell@gmail.com>
   Reviewed-By: Anna Henningsen <anna@addaleax.net>
   Reviewed-By: Andreas Madsen <amwebdk@gmail.com>

   

   ofrobots committed Feb 9, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 523a155
   • Browse repository at this point

   Copy the full SHA

   523a155 View commit details

   Browse the repository at this point in the history