Skip to content

deps: patch V8 to 6.4.388.41 #18522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.4.388.41 #18522

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins requested a review from targos February 2, 2018 08:45
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Feb 2, 2018
@MylesBorins
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12905/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1193/

@targos
Copy link
Member

targos commented Feb 2, 2018

@MylesBorins Practical question: I see that you have GPG-signed the commit. I know update-v8 does not work when commit.gpgsign is true. Do you have a work around?

@MylesBorins
Copy link
Contributor Author

@targos it just worked ¯\_(ツ)_/¯ .

I have gpgsign set to true in gitconfig

https://github.com/MylesBorins/dot-files/blob/master/.gitconfig#L36-L37

@targos
Copy link
Member

targos commented Feb 2, 2018

@MylesBorins Haha then maybe my config is wrong because I have to provide my passphrase for every commit and update-v8 does not ask for it interactively

@gibfahn
Copy link
Member

gibfahn commented Feb 5, 2018 •
edited
Loading

@MylesBorins Haha then maybe my config is wrong because I have to provide my passphrase for every commit and update-v8 does not ask for it interactively

@targos What version of gpg are you using? I think it gets cached by default with gpg2 (but not gpg1).

@MylesBorins
Copy link
Contributor Author

landed in 1f76482

@MylesBorins MylesBorins closed this Feb 5, 2018
MylesBorins added a commit that referenced this pull request Feb 5, 2018
@MylesBorins
deps: patch V8 to 6.4.388.41
1f76482 
PR-URL: #18522
Refs: v8/v8@6.4.388.40...6.4.388.41
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos
Copy link
Member

targos commented Feb 13, 2018

@gibfahn thanks! I fixed this with git config --global gpg.program gpg2

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MylesBorins @MayaLekova
deps: patch V8 to 6.4.388.41
bbf1883 
PR-URL: nodejs#18522
Refs: v8/v8@6.4.388.40...6.4.388.41
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MylesBorins @targos @gibfahn @fhinkel @cjihrig @nodejs-github-bot