Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove destructor from node_test_fixture #18524

Closed
wants to merge 1 commit into from
Closed

test: remove destructor from node_test_fixture #18524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/cctest/node_test_fixture.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,6 @@ class NodeTestFixture : public ::testing::Test {
protected:
v8::Isolate* isolate_;

~NodeTestFixture() {
TearDown();
}

virtual void SetUp() {
CHECK_EQ(0, uv_loop_init(&current_loop));
platform_ = new node::NodePlatform(8, nullptr);
Expand All @@ -86,7 +82,6 @@ class NodeTestFixture : public ::testing::Test {
}

virtual void TearDown() {
if (platform_ == nullptr) return;
platform_->Shutdown();
while (uv_loop_alive(&current_loop)) {
uv_run(&current_loop, UV_RUN_ONCE);
Expand Down
11 changes: 1 addition & 10 deletions test/cctest/test_aliased_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,7 @@

using node::AliasedBuffer;

class AliasBufferTest : public NodeTestFixture {
protected:
void SetUp() override {
NodeTestFixture::SetUp();
}

void TearDown() override {
NodeTestFixture::TearDown();
}
};
class AliasBufferTest : public NodeTestFixture {};

template<class NativeT>
void CreateOracleValues(NativeT* buf, size_t count) {
Expand Down