Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: nodejs/modules team now exists #18545

Closed
wants to merge 1 commit into from
Closed

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Feb 3, 2018

the nodejs/modules team has been created, changes who to ping for es modules

Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 3, 2018
@targos
Copy link
Member

targos commented Feb 3, 2018

There is @nodejs/esm for that. @nodejs/modules is more generally for the modules working group (maybe we should rename it @nodejs/modules-wg).

@devsnek
Copy link
Member Author

devsnek commented Feb 3, 2018

@targos will these two teams be consolidated or kept separate? (what should i do with this pr)

@targos
Copy link
Member

targos commented Feb 3, 2018

I don't know. If the people of the new team are all OK to be cc'd for every module issue or PR in core, we can remove nodejs/esm

@joyeecheung
Copy link
Member

joyeecheung commented Feb 3, 2018

cc @nodejs/esm are you in favor of merging @nodejs/esm into @nodejs/modules ?

BTW we can also make @nodejs/esm a child team of @nodejs/modules if people don't want to be cc'd for other module issues, although given that we want to make ESM interoperable with CJS modules, most issues of CJS modules also need to be considered by ESM and the fixes should be kept in sync whenever reasonable.

@jdalton
Copy link
Member

jdalton commented Feb 3, 2018

I'm cool with getting pinged for all things module (cjs/esm/node/wasm)

@giltayar
Copy link
Contributor

giltayar commented Feb 3, 2018

I'm probably not understanding what I'm getting into :-), but for me getting cc-ed on every module issue/PR would actually be a great way to get into things quickly.

@@ -31,7 +31,7 @@
| `test/*` | @nodejs/testing |
| `tools/node_modules/eslint`, `.eslintrc` | @not-an-aardvark, @silverwind, @trott |
| build | @nodejs/build |
| ES Modules | @bmeck, @Fishrock123, @guybedford, @MylesBorins, @targos |
| ES Modules | @nodejs/modules |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are talking about all things module...maybe this can be more specific, e.g. putting it down as lib/{internal/}module.js and src/module_wrap.*?

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 3, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 3, 2018

Mini-CI https://ci.nodejs.org/job/node-test-commit-light/211/

@devsnek would you be so kind and always trigger a CI after opening a PR? :-)

@devsnek
Copy link
Member Author

devsnek commented Feb 3, 2018

@BridgeAR can i do that yet? i haven't actually joined as a node collab yet, ci page doesn't show anything to let me start a run.

@BridgeAR
Copy link
Member

BridgeAR commented Feb 3, 2018

Oh, I see. In that case no. I thought that would already be the case.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member

BridgeAR commented Feb 6, 2018

Landed in 9686d87

@BridgeAR BridgeAR closed this Feb 6, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 6, 2018
Mention the new modules team.

PR-URL: nodejs#18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2018
@devsnek devsnek deleted the patch-4 branch February 6, 2018 13:33
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
Mention the new modules team.

PR-URL: #18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
Mention the new modules team.

PR-URL: #18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
Mention the new modules team.

PR-URL: #18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Mention the new modules team.

PR-URL: nodejs#18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.