-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release proposal: v2.2.1 #1856
Release proposal: v2.2.1 #1856
Conversation
PR-URL: nodejs#1856 Notable Changes: * http: reverts the removal of an undocumented `client` property on client connections, this property is being used in the wild, most notably by https://github.com/request/request which is used by npm. (Michaël Zasso) [nodejs#1852](nodejs#1852).
This LGTM, I'll follow the thread and will be available to test on OSX / CentOS. |
uh oh, not this again?? LGTM though! |
OSX:
Anyone got any clues on this? I don't think I've seen this failure before. Nightlies are here for testing if you have time: https://iojs.org/download/nightly/v2.2.1-nightly20150601c5a1009903/ |
Thought that was fixed in 4e2f999, cc: @yosuke-furukawa If someone could confirm that |
It's my test. I will investigate it . |
Why was the qs readme deleted? |
Weird git-ness originating several npm releases ago relating to case insensitive filesystems (maybe-ish). |
See 49bb7de |
PR-URL: nodejs#1856 Notable Changes: * http: reverts the removal of an undocumented `client` property on client connections, this property is being used in the wild, most notably by https://github.com/request/request which is used by npm. (Michaël Zasso) [nodejs#1852](nodejs#1852).
updated to remove the readme change, so frustrating |
hm... I can reproduce the error. sorry. |
running again @ https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/740/ |
released @ https://iojs.org/dist/latest/ |
We didn't remove that, right? |
yeah, probably not the best description, feel free to PR to fix it to something more accurate |
'revert the improper deprecation' is probably best, like I've done in the commit log. |
Ya, that sounds better @silverwind 👍 |
it wasn't deprecation that caused the problem though, it was changing the nature of it |
Then lets explain the actual problem itself. "Moving |
That's pretty |
please look at #1859 and give a tick if you think that's accurate, everyone who's commenting here |
PR-URL: nodejs/node#1856 Notable Changes: * http: reverts the removal of an undocumented `client` property on client connections, this property is being used in the wild, most notably by https://github.com/request/request which is used by npm. (Michaël Zasso) [#1852](nodejs#1852).
c5a1009903
] - build: avoid passing empty strings to build flags (Johan Bergström) #17895d83401086
] - doc: put SEMVER-MINOR on pre-load module fix 2.2.0 (Rod Vagg)4d6b768e5d
] - http: revert deprecation of client property (Michaël Zasso) #1852/R= @targos @mscdex @Fishrock123 @thefourtheye @silverwind @ChALkeR (anyone else want to review?)
I can push this out within an hour or two given some eyes and perhaps even some actual testing!