Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v2.2.1 #1856

Merged
merged 1 commit into from
Jun 1, 2015
Merged

Release proposal: v2.2.1 #1856

merged 1 commit into from
Jun 1, 2015

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 1, 2015

  • [c5a1009903] - build: avoid passing empty strings to build flags (Johan Bergström) #1789
  • [5d83401086] - doc: put SEMVER-MINOR on pre-load module fix 2.2.0 (Rod Vagg)
  • [4d6b768e5d] - http: revert deprecation of client property (Michaël Zasso) #1852

/R= @targos @mscdex @Fishrock123 @thefourtheye @silverwind @ChALkeR (anyone else want to review?)

I can push this out within an hour or two given some eyes and perhaps even some actual testing!

@rvagg rvagg changed the title 2015-05-31 io.js v2.2.1 Release Release proposal: v2.2.1 Jun 1, 2015
rvagg added a commit to rvagg/io.js that referenced this pull request Jun 1, 2015
PR-URL: nodejs#1856

Notable Changes:

* http: reverts the removal of an undocumented `client` property on client
  connections, this property is being used in the wild, most notably by
  https://github.com/request/request which is used by npm.
  (Michaël Zasso) [nodejs#1852](nodejs#1852).
@chrisdickinson
Copy link
Contributor

This LGTM, I'll follow the thread and will be available to test on OSX / CentOS.

@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

@Fishrock123
Copy link
Contributor

deps/npm/node_modules/request/node_modules/qs/Readme.md

uh oh, not this again??

LGTM though!

@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

OSX:

not ok 157 - test-dgram-send-callback-recursive.js
#/Users/iojs/build/workspace/iojs+any-pr+multi/nodes/osx1010/test/parallel/test-dgram-send-callback-recursive.js:15
#    throw new Error('infinite loop detected');
#          ^
#Error: infinite loop detected
#    at SendWrap.onsend [as callback] (/Users/iojs/build/workspace/iojs+any-pr+multi/nodes/osx1010/test/parallel/test-dgram-send-callback-recursive.js:15:11)
#    at Immediate._onImmediate (dgram.js:337:10)
#    at processImmediate [as _immediateCallback] (timers.js:371:17)

Anyone got any clues on this? I don't think I've seen this failure before.

Nightlies are here for testing if you have time: https://iojs.org/download/nightly/v2.2.1-nightly20150601c5a1009903/

@silverwind
Copy link
Contributor

Anyone got any clues on this

Thought that was fixed in 4e2f999, cc: @yosuke-furukawa

If someone could confirm that test-npm works without ssl errors, that'd be great.

@yosuke-furukawa
Copy link
Member

It's my test. I will investigate it .

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Jun 1, 2015
@domenic
Copy link
Contributor

domenic commented Jun 1, 2015

Why was the qs readme deleted?

@Fishrock123
Copy link
Contributor

Why was the qs readme deleted?

Weird git-ness originating several npm releases ago relating to case insensitive filesystems (maybe-ish).

@ChALkeR
Copy link
Member

ChALkeR commented Jun 1, 2015

See 49bb7de

PR-URL: nodejs#1856

Notable Changes:

* http: reverts the removal of an undocumented `client` property on client
  connections, this property is being used in the wild, most notably by
  https://github.com/request/request which is used by npm.
  (Michaël Zasso) [nodejs#1852](nodejs#1852).
@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

updated to remove the readme change, so frustrating

@yosuke-furukawa
Copy link
Member

hm... I can reproduce the error. sorry.
I should loosen the condition. I will pull request it soon.

@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

@rvagg rvagg merged commit fe84797 into nodejs:master Jun 1, 2015
@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

released @ https://iojs.org/dist/latest/

@thefourtheye
Copy link
Contributor

reverts the removal of an undocumented client property on client connection

We didn't remove that, right?

@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

yeah, probably not the best description, feel free to PR to fix it to something more accurate

@silverwind
Copy link
Contributor

'revert the improper deprecation' is probably best, like I've done in the commit log.

@thefourtheye
Copy link
Contributor

Ya, that sounds better @silverwind 👍

@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

it wasn't deprecation that caused the problem though, it was changing the nature of it

@thefourtheye
Copy link
Contributor

Then lets explain the actual problem itself. "Moving client to the IncomingMessage's prototype broke request, as it is expecting client to be the object's own property." Can we point the actual line which does this?

@silverwind
Copy link
Contributor

changing the nature of it

That's pretty improper in my book 😛

@rvagg
Copy link
Member Author

rvagg commented Jun 1, 2015

please look at #1859 and give a tick if you think that's accurate, everyone who's commenting here

andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
PR-URL: nodejs/node#1856

Notable Changes:

* http: reverts the removal of an undocumented `client` property on client
  connections, this property is being used in the wild, most notably by
  https://github.com/request/request which is used by npm.
  (Michaël Zasso) [#1852](nodejs#1852).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants