lint: move eslint to new plugin system #18566
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ tools/remark-* | |
| node_modules | ||
| benchmark/tmp | ||
| doc/**/*.js | ||
| !.eslintrc.js | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,264 @@ | ||
| 'use strict'; | ||
|
|
||
| const Module = require('module'); | ||
| const path = require('path'); | ||
|
|
||
| const NodePlugin = require('./tools/node_modules/eslint-plugin-node-core'); | ||
| NodePlugin.RULES_DIR = path.resolve(__dirname, 'tools', 'eslint-rules'); | ||
|
|
||
| const ModuleFindPath = Module._findPath; | ||
| const hacks = [ | ||
| 'eslint-plugin-node-core', | ||
| 'eslint-plugin-markdown', | ||
| 'babel-eslint', | ||
| ]; | ||
| Module._findPath = (request, paths, isMain) => { | ||
| const r = ModuleFindPath(request, paths, isMain); | ||
| if (!r && hacks.includes(request)) { | ||
| try { | ||
| return require.resolve(`./tools/node_modules/${request}`); | ||
| } catch (err) { | ||
| return require.resolve( | ||
| `./tools/node_modules/eslint/node_modules/${request}`); | ||
| } | ||
| } | ||
| return r; | ||
| }; | ||
|
|
||
| module.exports = { | ||
| root: true, | ||
| plugins: ['markdown', 'node-core'], | ||
| env: { node: true, es6: true }, | ||
| parser: 'babel-eslint', | ||
| parserOptions: { sourceType: 'script' }, | ||
| overrides: [ | ||
| { | ||
| files: [ | ||
| 'doc/api/esm.md', | ||
| '*.mjs', | ||
| 'test/es-module/test-esm-example-loader.js', | ||
| ], | ||
| parserOptions: { sourceType: 'module' }, | ||
| }, | ||
| ], | ||
| rules: { | ||
|
There was a problem hiding this comment. Can you either add back the sections from the old format or (my preference) sort this object alphabetically? |
||
| // Possible Errors | ||
| // http://eslint.org/docs/rules/#possible-errors | ||
| 'for-direction': 'error', | ||
| 'no-control-regex': 'error', | ||
| 'no-debugger': 'error', | ||
| 'no-dupe-args': 'error', | ||
| 'no-dupe-keys': 'error', | ||
| 'no-duplicate-case': 'error', | ||
| 'no-empty-character-class': 'error', | ||
| 'no-ex-assign': 'error', | ||
| 'no-extra-boolean-cast': 'error', | ||
| 'no-extra-parens': ['error', 'functions'], | ||
| 'no-extra-semi': 'error', | ||
| 'no-func-assign': 'error', | ||
| 'no-invalid-regexp': 'error', | ||
| 'no-irregular-whitespace': 'error', | ||
| 'no-obj-calls': 'error', | ||
| 'no-template-curly-in-string': 'error', | ||
| 'no-unexpected-multiline': 'error', | ||
| 'no-unreachable': 'error', | ||
| 'no-unsafe-negation': 'error', | ||
| 'use-isnan': 'error', | ||
| 'valid-typeof': 'error', | ||
|
|
||
| // Best Practices | ||
| // http://eslint.org/docs/rules/#best-practices | ||
| 'accessor-pairs': 'error', | ||
| 'array-callback-return': 'error', | ||
| 'dot-location': ['error', 'property'], | ||
| eqeqeq: ['error', 'smart'], | ||
| 'no-fallthrough': 'error', | ||
| 'no-global-assign': 'error', | ||
| 'no-multi-spaces': ['error', { ignoreEOLComments: true }], | ||
| 'no-octal': 'error', | ||
| 'no-proto': 'error', | ||
| 'no-redeclare': 'error', | ||
| 'no-restricted-properties': [ | ||
| 'error', | ||
| { | ||
| object: 'assert', | ||
| property: 'deepEqual', | ||
| message: 'Use assert.deepStrictEqual().', | ||
| }, | ||
| { | ||
| object: 'assert', | ||
| property: 'notDeepEqual', | ||
| message: 'Use assert.notDeepStrictEqual().', | ||
| }, | ||
| { | ||
| object: 'assert', | ||
| property: 'equal', | ||
| message: 'Use assert.astrictEqual() rather than assert.equal().', | ||
| }, | ||
| { | ||
| object: 'assert', | ||
| property: 'notEqual', | ||
| message: 'Use assert.notStrictEqual() rather than assert.notEqual().', | ||
| }, | ||
| { | ||
| property: '__defineGetter__', | ||
| message: '__defineGetter__ is deprecated.', | ||
| }, | ||
| { | ||
| property: '__defineSetter__', | ||
| message: '__defineSetter__ is deprecated.', | ||
| } | ||
| ], | ||
| 'no-return-await': 'error', | ||
| 'no-self-assign': 'error', | ||
| 'no-throw-literal': 'error', | ||
| 'no-unused-labels': 'error', | ||
| 'no-useless-call': 'error', | ||
| 'no-useless-concat': 'error', | ||
| 'no-useless-escape': 'error', | ||
| 'no-useless-return': 'error', | ||
| 'no-void': 'error', | ||
| 'no-with': 'error', | ||
|
|
||
| // Strict Mode | ||
| // http://eslint.org/docs/rules/#strict-mode | ||
| strict: ['error', 'global'], | ||
|
|
||
| // Variables | ||
| // http://eslint.org/docs/rules/#variables | ||
| 'no-delete-var': 'error', | ||
| 'no-undef': 'error', | ||
| 'no-unused-vars': ['error', { args: 'none' }], | ||
| 'no-use-before-define': ['error', { | ||
| classes: true, | ||
| functions: false, | ||
| variables: false, | ||
| }], | ||
|
|
||
| // Node.js and CommonJS | ||
| // http://eslint.org/docs/rules/#nodejs-and-commonjs | ||
| 'no-mixed-requires': 'error', | ||
| 'no-new-require': 'error', | ||
| 'no-path-concat': 'error', | ||
| 'no-restricted-modules': ['error', 'sys'], | ||
|
|
||
| // Stylistic Issues | ||
| // http://eslint.org/docs/rules/#stylistic-issues' | ||
| 'block-spacing': 'error', | ||
| 'brace-style': ['error', '1tbs', { allowSingleLine: true }], | ||
| 'comma-dangle': ['error', 'only-multiline'], | ||
| 'comma-spacing': 'error', | ||
| 'comma-style': 'error', | ||
| 'computed-property-spacing': 'error', | ||
| 'eol-last': 'error', | ||
| 'func-call-spacing': 'error', | ||
| 'func-name-matching': 'error', | ||
| 'func-style': ['error', 'declaration', { allowArrowFunctions: true }], | ||
| indent: ['error', 2, { | ||
| ArrayExpression: 'first', | ||
| CallExpression: { arguments: 'first' }, | ||
| FunctionDeclaration: { parameters: 'first' }, | ||
| FunctionExpression: { parameters: 'first' }, | ||
| MemberExpression: 'off', | ||
| ObjectExpression: 'first', | ||
| SwitchCase: 1, | ||
| }], | ||
| 'key-spacing': ['error', { mode: 'minimum' }], | ||
| 'keyword-spacing': 'error', | ||
| 'linebreak-style': ['error', 'unix'], | ||
| 'max-len': ['error', { | ||
| code: 80, | ||
| ignorePattern: '^// Flags:', | ||
| ignoreRegExpLiterals: true, | ||
| ignoreUrls: true, | ||
| tabWidth: 2, | ||
| }], | ||
| 'new-parens': 'error', | ||
| 'no-lonely-if': 'error', | ||
| 'no-mixed-spaces-and-tabs': 'error', | ||
| 'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }], | ||
| /* eslint-disable max-len, quotes */ | ||
| 'no-restricted-syntax': [ | ||
| 'error', | ||
| { | ||
| selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`, | ||
| message: 'use a regular expression for second argument of assert.throws()', | ||
| }, | ||
| { | ||
| selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]`, | ||
| message: 'assert.throws() must be invoked with at least two arguments.', | ||
| }, | ||
| { | ||
| selector: `CallExpression[callee.name='setTimeout'][arguments.length<2]`, | ||
| message: 'setTimeout() must be invoked with at least two arguments.', | ||
| }, | ||
| { | ||
| selector: `CallExpression[callee.name='setInterval'][arguments.length<2]`, | ||
| message: 'setInterval() must be invoked with at least 2 arguments.', | ||
| }, | ||
| { | ||
| selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]', | ||
| message: 'Use new keyword when throwing an Error.', | ||
| } | ||
| ], | ||
| /* eslint-enable max-len, quotes */ | ||
| 'no-tabs': 'error', | ||
| 'no-trailing-spaces': 'error', | ||
| 'object-curly-spacing': ['error', 'always'], | ||
| 'one-var-declaration-per-line': 'error', | ||
| 'operator-linebreak': ['error', 'after'], | ||
| quotes: ['error', 'single', 'avoid-escape'], | ||
| semi: 'error', | ||
| 'semi-spacing': 'error', | ||
| 'space-before-blocks': ['error', 'always'], | ||
| 'space-before-function-paren': ['error', { | ||
| anonymous: 'never', | ||
| named: 'never', | ||
| asyncArrow: 'always', | ||
| }], | ||
| 'space-in-parens': ['error', 'never'], | ||
| 'space-infix-ops': 'error', | ||
| 'space-unary-ops': 'error', | ||
| 'unicode-bom': 'error', | ||
|
|
||
| // ECMAScript 6 | ||
| // http://eslint.org/docs/rules/#ecmascript-6 | ||
| 'arrow-parens': ['error', 'always'], | ||
| 'arrow-spacing': ['error', { before: true, after: true }], | ||
| 'constructor-super': 'error', | ||
| 'no-class-assign': 'error', | ||
| 'no-confusing-arrow': 'error', | ||
| 'no-const-assign': 'error', | ||
| 'no-dupe-class-members': 'error', | ||
| 'no-new-symbol': 'error', | ||
| 'no-this-before-super': 'error', | ||
| 'prefer-const': ['error', { ignoreReadBeforeAssign: true }], | ||
| 'rest-spread-spacing': 'error', | ||
| 'symbol-description': 'error', | ||
| 'template-curly-spacing': 'error', | ||
|
|
||
| // Custom rules in from eslint-plugin-node-core | ||
| 'node-core/no-unescaped-regexp-dot': 'error', | ||
| }, | ||
| globals: { | ||
| COUNTER_HTTP_CLIENT_REQUEST: false, | ||
| COUNTER_HTTP_CLIENT_RESPONSE: false, | ||
| COUNTER_HTTP_SERVER_REQUEST: false, | ||
| COUNTER_HTTP_SERVER_RESPONSE: false, | ||
| COUNTER_NET_SERVER_CONNECTION: false, | ||
| COUNTER_NET_SERVER_CONNECTION_CLOSE: false, | ||
| DTRACE_HTTP_CLIENT_REQUEST: false, | ||
| DTRACE_HTTP_CLIENT_RESPONSE: false, | ||
| DTRACE_HTTP_SERVER_REQUEST: false, | ||
| DTRACE_HTTP_SERVER_RESPONSE: false, | ||
| DTRACE_NET_SERVER_CONNECTION: false, | ||
| DTRACE_NET_STREAM_END: false, | ||
| LTTNG_HTTP_CLIENT_REQUEST: false, | ||
| LTTNG_HTTP_CLIENT_RESPONSE: false, | ||
| LTTNG_HTTP_SERVER_REQUEST: false, | ||
| LTTNG_HTTP_SERVER_RESPONSE: false, | ||
| LTTNG_NET_SERVER_CONNECTION: false, | ||
| LTTNG_NET_STREAM_END: false, | ||
| internalBinding: false, | ||
| }, | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to put these into a separate file (either a JSON or a .js), and re-export that from here. That way we can separate the hack from the actual rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd rather not just for simplicity's sake