Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.4.388.42 #18578

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.4.388.42 #18578

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Feb 5, 2018
@MylesBorins
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12949/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1199/

@MylesBorins
Copy link
Contributor Author

If everything is green could we fastrack?

@MylesBorins
Copy link
Contributor Author

@nodejs/build odroid is failing during compilation of openssl

@Trott
Copy link
Member

Trott commented Feb 6, 2018

@nodejs/build odroid is failing during compilation of openssl

Try again, maybe? The problematic host (1 of 3) is now offline so hopefully it will work this time?

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2018
MylesBorins added a commit to MylesBorins/node that referenced this pull request Feb 7, 2018
@MylesBorins
deps: patch V8 to 6.4.388.42
d0e4d4e 
PR-URL: nodejs#18578
Refs: v8/v8@6.4.388.41...6.4.388.42
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins
Copy link
Contributor Author

landed in d0e4d4e

@MylesBorins MylesBorins closed this Feb 7, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MylesBorins @MayaLekova
deps: patch V8 to 6.4.388.42
d04895d 
PR-URL: nodejs#18578
Refs: v8/v8@6.4.388.41...6.4.388.42
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MylesBorins @Trott @targos @cjihrig @BridgeAR @nodejs-github-bot