build,win: replace run-python subroutine with single find_python call #18621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subroutine does not work as a replacement for the `python` command since one cannot use a subroutine call in a `for /F` loop.
nodejs-github-bot
added
build
2 tasks
bzoz
approved these changes
Feb 7, 2018
| @@ -165,6 +165,9 @@ if "%target%"=="Clean" echo deleting %~dp0deps\icu | |||
| if "%target%"=="Clean" rmdir /S /Q %~dp0deps\icu | |||
| :no-depsicu | |||
|
|
|||
| call tools\msvs\find_python.cmd | |||
There was a problem hiding this comment.
Maybe redirect to NUL, to avoid ERROR: The system was unable to find the specified registry key or value.?
There was a problem hiding this comment.
I don't really like combining unrelated fixes in a single PR (this line was just moved from :run-python). Plus, I think it would be better to fix this inside find_python.cmd itself.
richardlau
approved these changes
Feb 14, 2018
|
Failures are unrelated. |
|
...but the commit title is to too long. @seishun, could you make the commit title <50 chars long? |
|
I don't think so, and it's not a requirement: https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
|
|
Landed in cfad441 |
bzoz
pushed a commit
that referenced
this pull request
Feb 15, 2018
A subroutine does not work as a replacement for the `python` command since one cannot use a subroutine call in a `for /F` loop. PR-URL: #18621 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
A subroutine does not work as a replacement for the `python` command since one cannot use a subroutine call in a `for /F` loop. PR-URL: #18621 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
A subroutine does not work as a replacement for the `python` command since one cannot use a subroutine call in a `for /F` loop. PR-URL: #18621 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
A subroutine does not work as a replacement for the `python` command since one cannot use a subroutine call in a `for /F` loop. PR-URL: nodejs#18621 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Should this be backported to |
|
@MylesBorins seems pointless. |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41235 Refs: nodejs#18621 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subroutine does not work as a replacement for the
pythoncommandsince one cannot use a subroutine call in a
for /Floop.This is an alternative to #17293 and #17804. I realized that
find_python.cmdadds Python toPATH, so there is no need to introduce a variable.I still slightly prefer #17293 for the reasons outlined in #17804 (basically, extra maintenance), but I prefer this PR to #17804 since it doesn't introduce an extra variable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build