configure: remove workarounds for GCC < 4.8 #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can't compile io.js anyway.
|
gcc_version and clang are currently used by libuv but see libuv/libuv#76. Once that lands, it's safe to remove them.
The idea was to be compatible with gcc 4.6, which doesn't know about -std=c++11. I guess we can change that because building with 4.6 doesn't work anyway. |
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 20, 2014
They can't compile io.js anyway. PR-URL: #187 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in ef10827. Thanks, Nikolai! |
minervapanda
pushed a commit
to minervapanda/node
that referenced
this pull request
Oct 9, 2016
jasongin
added a commit
to jasongin/nodejs
that referenced
this pull request
Mar 23, 2017
- Simplify conversion to/from napi_value - Better names for CallbackWrapper template params - Fatal error when trying to set setter return value - Use node::arraysize - Replace v8::Handle with v8::Local - Align the star after v8::Isolate
boingoing
pushed a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
- Simplify conversion to/from napi_value - Better names for CallbackWrapper template params - Fatal error when trying to set setter return value - Use node::arraysize - Replace v8::Handle with v8::Local - Align the star after v8::Isolate
This was referenced Jul 21, 2021
syg
pushed a commit
to syg/node
that referenced
this pull request
Jun 20, 2024
) (nodejs#188) Co-authored-by: Michael Lippautz <michael.lippautz@gmail.com>
eti-p-doray
pushed a commit
to eti-p-doray/node
that referenced
this pull request
Aug 28, 2024
) (nodejs#188) Co-authored-by: Michael Lippautz <michael.lippautz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can't compile io.js anyway.
Additionally, it seems the 'gcc_version' variable is no longer used in config.gypi, perhaps it can be removed too? The 'clang' variable is now only used to enable this monstrosity, which was apparently copied from V8. However, V8 currently enables it based only on the OS, which makes sense, since only Mac OS users are going to use XCode. Maybe io.js could do the same, eliminating the need to detect compilers?
On a less related note, why does io.js use -std=gnu++0x instead of -std=c++11? I've tried the latter and it builds just fine.