Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: replace magic numbers by named constants #18757

Closed
wants to merge 1 commit into from
Closed

fs: replace magic numbers by named constants #18757

wants to merge 1 commit into from

Conversation

daynin
Copy link
Contributor

@daynin daynin commented Feb 13, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Feb 13, 2018
BridgeAR
BridgeAR reviewed Feb 13, 2018
View reviewed changes
lib/fs.js Outdated
if (ch === 92/*'\'*/ || ch === 47/*'/'*/)
const isSeparator = ch === CHAR_BACKWARD_SLASH ||
ch === CHAR_FORWARD_SLASH;
if (isSeparator)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the extra variable could also just be replaces with a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR done

BridgeAR
BridgeAR reviewed Feb 13, 2018
View reviewed changes
lib/fs.js Outdated
@@ -1838,7 +1842,9 @@ if (isWindows) {
nextPart = function nextPart(p, i) {
for (; i < p.length; ++i) {
const ch = p.charCodeAt(i);
if (ch === 92/*'\'*/ || ch === 47/*'/'*/)

// if separator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could this be changed so something like "Check for a separator character"?

And please always begin comments with a capital letter :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR ok, sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR done

@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13144/

benjamingr
benjamingr approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 13, 2018
MylesBorins
MylesBorins approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 13, 2018
@mmarchini
Copy link
Contributor

CI before landing: https://ci.nodejs.org/job/node-test-pull-request/13184/

@mmarchini
Copy link
Contributor

New CI since we had infra problems on OSX yesterday: https://ci.nodejs.org/job/node-test-pull-request/13199/

mmarchini pushed a commit that referenced this pull request Feb 16, 2018
@daynin
fs: replace magic numbers by named constants
d8d84ee 
PR-URL: #18757
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
@mmarchini
Copy link
Contributor

Landed in d8d84ee. Thanks!

@mmarchini mmarchini closed this Feb 16, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@daynin @MylesBorins
fs: replace magic numbers by named constants
4e66bc3 
PR-URL: #18757
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@daynin @MylesBorins
fs: replace magic numbers by named constants
5b75572 
PR-URL: #18757
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@daynin @MayaLekova
fs: replace magic numbers by named constants
b7362b4 
PR-URL: nodejs#18757
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mmarchini mmarchini mmarchini approved these changes

@richardlau richardlau richardlau approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@daynin @BridgeAR @mmarchini @jasnell @MylesBorins @benjamingr @richardlau @vdeturckheim @nodejs-github-bot