-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: actually test tty getColorDepth() #18800
Merged
Fishrock123
merged 2 commits into
nodejs:master
from
Fishrock123:actually-test-tty-get-color-depth
Feb 20, 2018
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert').strict; | ||
/* eslint-disable no-restricted-properties */ | ||
const { WriteStream } = require('tty'); | ||
|
||
const fd = common.getTTYfd(); | ||
const writeStream = new WriteStream(fd); | ||
|
||
{ | ||
const depth = writeStream.getColorDepth(); | ||
|
||
assert.equal(typeof depth, 'number'); | ||
assert(depth >= 1 && depth <= 24); | ||
|
||
if (depth === 1) { | ||
// Terminal does not support colors, compare to a value that would. | ||
assert.notEqual(writeStream.getColorDepth({ COLORTERM: '1' }), depth); | ||
} else { | ||
// Terminal supports colors, compare to a value that would not. | ||
assert.notEqual(writeStream.getColorDepth({ TERM: 'dumb' }), depth); | ||
} | ||
} | ||
|
||
// Deactivate colors | ||
{ | ||
const tmp = process.env.NODE_DISABLE_COLORS; | ||
process.env.NODE_DISABLE_COLORS = 1; | ||
|
||
const depth = writeStream.getColorDepth(); | ||
|
||
assert.equal(depth, 1); | ||
|
||
process.env.NODE_DISABLE_COLORS = tmp; | ||
} |
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something similar wa sin here at some point and is used in another test file. It would be good to consolidate in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is, I'm not sure where it is at. If there are tests somewhere that I missed that use something like this, they probably don't actually work...? I couldn't find any in a quick look.
There are some tests that don't even bother to go for something like this and just go for fd 0 instead. (Which could probably be added to the lookup list here? I'll do that.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one in
sequential/test-async-wrap-getasyncid.js
. And zero was removed because it can cause issues on Windows.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That part of that test definitely never ever runs. 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move that out next and base it off of this then, I suppose.