test: check symbols in shared lib #18806

yhwang · 2018-02-15T22:36:33Z

When building the node with --shared option, we need
to verify the symbols in shared lib instead of executable.

Refs: #18535

Signed-off-by: Yihong Wang yh.wang@ibm.com

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

test

richardlau · 2018-02-16T00:18:03Z

test/parallel/test-postmortem-metadata.js

+  // There is no nm in Windows, maybe use dumpbin instead.
+  // However, we still try to compose the correct shared lib path
+  if (common.isWindows) {
+    args.push(path.join(path.dirname(process.execPath), 'node.dll'));


I wonder if the logic for getting the shared lib instead of the stub executable is worth putting in the test/common/shared-lib-util.js being added in #18626. The platform specific logic could then be kept out of these changes.

sure. that would be great! Since that PR is not landed yet. I will do that after the merge.

@richardlau per your suggestion and the PR is landed, I moved the shared lib path logic into test/common/shared-lib-util.js

cjihrig · 2018-02-16T17:50:44Z

test/parallel/test-postmortem-metadata.js

+const { getSharedLibPath } = require('../common/shared-lib-util.js');
+
+// For shared lib case, check shared lib instead
+if (process.config.variables.node_shared) {


Why not just conditionally create args?

richardlau · 2018-02-16T18:58:38Z

test/common/shared-lib-util.js

@@ -27,3 +27,17 @@ exports.addLibraryPath = function(env) {
    (env.PATH ? env.PATH + path.delimiter : '') +
    path.dirname(process.execPath);
 };
+
+// Get get the full path of shared lib


One too many get's 😁.

oops....... thanks @richardlau . fixed

BridgeAR · 2018-02-17T04:45:51Z

CI https://ci.nodejs.org/job/node-test-pull-request/13235/

yhwang · 2018-02-19T17:37:09Z

debian8-x64 failed on async-hooks/test-getaddrinforeqwrap test case. The change only modify test case parallel/test-postmortem-metadata. The failure should be irrelevant. async-hooks/test-getaddrinforeqwrap is not in flaky list. Let me kick off another CI.

https://ci.nodejs.org/job/node-test-commit/16376/

yhwang · 2018-02-19T20:25:56Z

previous CI passed the windows build and the second CI passed the linux test. I think it's green for this change.

When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com>

yhwang · 2018-02-20T22:43:13Z

rebased because of the conflict and new CI: https://ci.nodejs.org/job/node-test-commit/16393/

addaleax · 2018-02-21T21:24:48Z

Landed in ab7c627

When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

yhwang · 2018-02-21T23:06:19Z

thanks @addaleax

When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: nodejs#18806 Refs: nodejs#18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #18806 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 15, 2018

richardlau reviewed Feb 16, 2018

View reviewed changes

yhwang force-pushed the sharedlib-test-fix-postmortem branch from beedb23 to 39c2edf Compare February 16, 2018 17:35

cjihrig reviewed Feb 16, 2018

View reviewed changes

yhwang force-pushed the sharedlib-test-fix-postmortem branch from 39c2edf to 79842cc Compare February 16, 2018 18:17

richardlau approved these changes Feb 16, 2018

View reviewed changes

richardlau reviewed Feb 16, 2018

View reviewed changes

yhwang force-pushed the sharedlib-test-fix-postmortem branch from 79842cc to 0da2151 Compare February 16, 2018 19:39

BridgeAR approved these changes Feb 17, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2018

cjihrig approved these changes Feb 17, 2018

View reviewed changes

gibfahn approved these changes Feb 19, 2018

View reviewed changes

hiroppy approved these changes Feb 19, 2018

View reviewed changes

test: check symbols in shared lib

01374fe

When building the node with `--shared` option, we need to verify the symbols in shared lib instead of executable. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com>

yhwang force-pushed the sharedlib-test-fix-postmortem branch from 0da2151 to 01374fe Compare February 20, 2018 22:36

addaleax approved these changes Feb 21, 2018

View reviewed changes

addaleax closed this Feb 21, 2018

yhwang deleted the sharedlib-test-fix-postmortem branch February 21, 2018 23:05

MylesBorins mentioned this pull request Mar 6, 2018

v9.8.0 proposal #19181

Merged

MylesBorins added the land-on-v8.x label Aug 7, 2018

MylesBorins mentioned this pull request Aug 16, 2018

v8.12.0 proposal #21593

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: check symbols in shared lib #18806

test: check symbols in shared lib #18806

yhwang commented Feb 15, 2018

richardlau Feb 16, 2018

yhwang Feb 16, 2018

yhwang Feb 16, 2018

cjihrig Feb 16, 2018

yhwang Feb 16, 2018

yhwang Feb 16, 2018

richardlau Feb 16, 2018

yhwang Feb 16, 2018

BridgeAR commented Feb 17, 2018

yhwang commented Feb 19, 2018 •

edited

Loading

yhwang commented Feb 19, 2018

yhwang commented Feb 20, 2018

addaleax commented Feb 21, 2018

yhwang commented Feb 21, 2018

test: check symbols in shared lib #18806

test: check symbols in shared lib #18806

Conversation

yhwang commented Feb 15, 2018

Checklist

Affected core subsystem(s)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BridgeAR commented Feb 17, 2018

yhwang commented Feb 19, 2018 • edited Loading

yhwang commented Feb 19, 2018

yhwang commented Feb 20, 2018

addaleax commented Feb 21, 2018

yhwang commented Feb 21, 2018

yhwang commented Feb 19, 2018 •

edited

Loading