Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix warnings in addon tests #18810

Closed
wants to merge 1 commit into from
Closed

test: fix warnings in addon tests #18810

wants to merge 1 commit into from

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Feb 16, 2018 •
edited
Loading

The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

CI: https://ci.nodejs.org/job/node-test-pull-request/13190/

@ofrobots
test: fix warnings in addon tests
51a71c8 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: nodejs#18632
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Feb 16, 2018
@ofrobots ofrobots mentioned this pull request Feb 16, 2018
Closed
4 tasks
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
mhdawson
mhdawson approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 16, 2018

CI failure appears to be unrelated. As this is a test change, and it has sign off, will land.

jasnell pushed a commit that referenced this pull request Feb 16, 2018
@ofrobots @jasnell
test: fix warnings in addon tests
6ab288f 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

PR-URL: #18810
Refs: #18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell
Copy link
Member

jasnell commented Feb 16, 2018

Landed in 6ab288f

@jasnell jasnell closed this Feb 16, 2018
@ofrobots ofrobots deleted the old-make-callback-warnings branch February 17, 2018 01:22
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@ofrobots @MylesBorins
test: fix warnings in addon tests
d889767 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

PR-URL: #18810
Refs: #18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@ofrobots @MylesBorins
test: fix warnings in addon tests
840a2ea 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

PR-URL: #18810
Refs: #18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@ofrobots @MylesBorins
test: fix warnings in addon tests
dc45685 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: #18632

PR-URL: #18810
Refs: #18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@ofrobots @MayaLekova
test: fix warnings in addon tests
66223ba 
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.

Ref: nodejs#18632

PR-URL: nodejs#18810
Refs: nodejs#18632
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins
Copy link
Contributor

I've set as don't land for 8.x, please lmk if this is a mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ofrobots @jasnell @MylesBorins @cjihrig @mhdawson @BridgeAR @nodejs-github-bot