Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace var for (let|const) in utilities module #18814

Closed
wants to merge 1 commit into from
Closed

src: replace var for (let|const) in utilities module #18814

wants to merge 1 commit into from

Conversation

jvelezpo
Copy link
Contributor

Update Utilities module to replace var for let or const depending on the case.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

utils

@jvelezpo
src: replace var for (let|const) in utilities module
ec1632e 
Update Utilities module to replace var for let or const
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Feb 16, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
@BridgeAR
Copy link
Member

Light-CI https://ci.nodejs.org/job/node-test-commit-light/278/ (this should be enough for this PR)

@jasnell
Copy link
Member

jasnell commented Feb 16, 2018

Code changes like this really ought to have a full CI run.. https://ci.nodejs.org/job/node-test-pull-request/13223/ ... it's likely overkill but still preferable.

@jvelezpo
Copy link
Contributor Author

Hey @jasnell first thanks for taking the time to read and review this PR.
This CI you send...it has been ther more than 4 hours running already. Is that normal?

@BridgeAR
Copy link
Member

Landed in ca79fc5 🎉

@BridgeAR BridgeAR closed this Feb 22, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 22, 2018
@jvelezpo @BridgeAR
src: replace var for (let|const) in utilities module
ca79fc5 
Update Utilities module to replace var for let or const

PR-URL: nodejs#18814
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins pushed a commit that referenced this pull request Mar 6, 2018
@jvelezpo @MylesBorins
src: replace var for (let|const) in utilities module
d7f01bf 
Update Utilities module to replace var for let or const

PR-URL: #18814
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@jvelezpo @MayaLekova
src: replace var for (let|const) in utilities module
17b4aaa 
Update Utilities module to replace var for let or const

PR-URL: nodejs#18814
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@jvelezpo jvelezpo deleted the utils-replace-var branch September 6, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@mmarchini mmarchini mmarchini approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jvelezpo @BridgeAR @jasnell @mmarchini @MylesBorins @vsemozhetbyt @nodejs-github-bot