Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix unrelated variable name changes #18823

Closed
wants to merge 1 commit into from
Closed

test: fix unrelated variable name changes #18823

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

Managed to accidentally sneak in unrelated variable name changes in e9ac80b

This reverts that error. My bad. 😞

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@apapirovski apapirovski added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 16, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 16, 2018
@apapirovski
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13219/

mhdawson
mhdawson approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
@BridgeAR
Copy link
Member

Landed in 94e8d2a 🎉

@BridgeAR BridgeAR closed this Feb 16, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 16, 2018
@apapirovski @BridgeAR
test: fix unrelated variable name changes
94e8d2a 
PR-URL: nodejs#18823
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@apapirovski apapirovski deleted the fix-unrelated-changes branch February 16, 2018 21:11
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Closed
2 tasks
@MylesBorins
Copy link
Contributor

This needs to be backported with #18720

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@apapirovski @MayaLekova
test: fix unrelated variable name changes
6b11b5d 
PR-URL: nodejs#18823
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apapirovski @BridgeAR @MylesBorins @mhdawson @nodejs-github-bot