-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9.x backport] module: main w/o extension, pjson cache (#18728, #18788) #18923
Conversation
I'd like to reopen this for consideration against #19040. |
@MylesBorins re your comments in our TSC meeting about modules work going on, I'm guessing that we may want to hold off on pushing this kind of change out via Current just now until the modules group gets a chance to get its footing and make some more comprehensive decisions about ESM? |
@rvagg thanks for checking on this one. It does fix a backwards compatibility concern so that's the main reason I'm pushing it. This is relatively non-controversial so shouldn't be too much of an issue I'd expect, but will be interesting to hear what Myles thinks as well. The main blocker at the moment though is that CI is failing and I haven't had a moment to look into this further...! If I can't get to the fix in time, no problem at all to skip this for now. |
This adds support for ensuring that the top-level main into Node is supported loading when it has no extension for backwards-compat with NodeJS bin workflows. In addition package.json caching is implemented in the module lookup process. PR-URL: nodejs#18728 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#18788 Refs: nodejs#18728 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
I finally fixed the issue here. |
This adds support for ensuring that the top-level main into Node is supported loading when it has no extension for backwards-compat with NodeJS bin workflows. In addition package.json caching is implemented in the module lookup process. Backport-PR-URL: #18923 PR-URL: #18728 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
landed in 50d1233...39e032f |
This includes the v9 backports for #18728 and #18788.
The conflict resolution is only in the first commit for #18728 here.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes