Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-http-connect #18941

Closed
wants to merge 1 commit into from
Closed

test: fix test-http-connect #18941

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

See #18940

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 22, 2018
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 22, 2018
@addaleax
Copy link
Member

Can you add a Fixes: tag and merge it? I’m kicking off CI but we should just land it as soon as some jobs come back good.

CI: https://ci.nodejs.org/job/node-test-commit/16445/

@addaleax
Copy link
Member

Landed in fecc64d

@addaleax addaleax closed this Feb 22, 2018
addaleax pushed a commit that referenced this pull request Feb 22, 2018
@BridgeAR @addaleax
test: fix test-http-connect
fecc64d 
Fixes: #18940
PR-URL: #18941
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR
Copy link
Member Author

@addaleax thanks for landing it and adding the fixes entry in the commit message :)

@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@lpinca
Copy link
Member

lpinca commented Mar 7, 2018

This depends on #18868 which is semver-major. I think it should not be backported.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@BridgeAR @MayaLekova
test: fix test-http-connect
acc76b0 
Fixes: nodejs#18940
PR-URL: nodejs#18941
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR deleted the fix-test-http-connect branch April 1, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BridgeAR @addaleax @MylesBorins @lpinca @cjihrig @nodejs-github-bot