Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore: ignore VS compiler output in deps/v8 #18952

Closed
wants to merge 2 commits into from
Closed

gitignore: ignore VS compiler output in deps/v8 #18952

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Feb 23, 2018

Just compiled node on Windows and got some untracked files:

PS D:\Documents\GitHub\nodejs\node> git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        deps/v8/src/Release/
        deps/v8/src/inspector/Release/

nothing added to commit but untracked files present (use "git add" to track)

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 23, 2018
bnoordhuis
bnoordhuis approved these changes Feb 23, 2018
View reviewed changes
.gitignore Outdated
@@ -122,3 +122,6 @@ deps/uv/docs/src/guide/

# do not override V8's .gitignore
!deps/v8/**
# ignore VS compiler output unhandled by V8's .gitignore
deps/v8/src/Release/
deps/v8/src/inspector/Release/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also want to add Debug paths.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2018
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 23, 2018
@targos
Copy link
Member Author

targos commented Feb 23, 2018

Is there a CI job worth running for changes like this?

@bnoordhuis
Copy link
Member

@targos No. Just merge it, no need to wait 72 hours.

@targos
Copy link
Member Author

targos commented Feb 24, 2018

Landed in 15e41a9

@targos targos closed this Feb 24, 2018
@targos targos deleted the v8-ignore-release branch February 24, 2018 12:54
targos added a commit that referenced this pull request Feb 24, 2018
@targos
tools: ignore VS compiler output in deps/v8
15e41a9 
PR-URL: #18952
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Feb 26, 2018
@targos @addaleax
tools: ignore VS compiler output in deps/v8
0075f8c 
PR-URL: nodejs#18952
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@targos @addaleax
tools: ignore VS compiler output in deps/v8
d255db3 
PR-URL: #18952
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax addaleax mentioned this pull request Feb 27, 2018
Closed
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@targos @MayaLekova
tools: ignore VS compiler output in deps/v8
f47c496 
PR-URL: nodejs#18952
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@targos @MylesBorins
tools: ignore VS compiler output in deps/v8
0fc4d32 
PR-URL: #18952
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@targos @MylesBorins
tools: ignore VS compiler output in deps/v8
c29cc27 
PR-URL: #18952
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@targos @MylesBorins
tools: ignore VS compiler output in deps/v8
ce62e14 
PR-URL: #18952
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @bnoordhuis @lpinca @cjihrig @tniessen @BridgeAR @MylesBorins @nodejs-github-bot