Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x] test: remove orphaned entries from status #19042

Closed
wants to merge 1 commit into from

Conversation

kfarnung
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Feb 27, 2018
@kfarnung kfarnung self-assigned this Feb 27, 2018
@MylesBorins
Copy link
Contributor

@kfarnung was this meant to be submitted against v6.x? A handful of these tests you've removed still exists on the release line

CI: https://ci.nodejs.org/job/node-test-pull-request/13750/

@kfarnung
Copy link
Contributor Author

@MylesBorins I created a relatively simple script for finding these. I spot checked the current state of the PR against both v6.x and v6.x-staging and it looks correct to me.

@kfarnung
Copy link
Contributor Author

Kicked off a new CI run: https://ci.nodejs.org/job/node-test-pull-request/13755/

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

landed in 12806ac

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
PR-URL: #19042
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@kfarnung kfarnung deleted the v6.x-backport-18092 branch March 20, 2018 17:59
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
PR-URL: #19042
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
PR-URL: #19042
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants