-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: util: document --trace-deprecation #191
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any reason tracing isn't enabled by default? |
IIRC, it was deemed too spammy. |
if we only show the calling function's filename, line number, and function name, it should be the same amonut of lines and a lot more useful. |
This makes require('process') always return a reference to the global process object. PR-URL: nodejs#206 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
That's a bigger change though (one that you are more than welcome to take on if you want.) Can you LGTM this doc change so I can land it? |
more docs are always better! 👍 |
Document the --trace-deprecation flag and the `process` properties that affect util.deprecate(). Fixes: nodejs#190 PR-URL: nodejs#191 Reviewed-By: Jonathan Ong <me@jongleberry.com>
bnoordhuis
force-pushed
the
document-trace-deprecation
branch
from
December 30, 2014 22:49
2797229
to
8b04161
Compare
This was referenced Jun 23, 2022
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the --trace-deprecation flag and the
process
properties thataffect util.deprecate().
R=@jonathanong