Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: util: document --trace-deprecation #191

Closed

Conversation

bnoordhuis
Copy link
Member

Document the --trace-deprecation flag and the process properties that
affect util.deprecate().

R=@jonathanong

@jonathanong
Copy link
Contributor

Any reason tracing isn't enabled by default?

@bnoordhuis
Copy link
Member Author

IIRC, it was deemed too spammy.

@jonathanong
Copy link
Contributor

if we only show the calling function's filename, line number, and function name, it should be the same amonut of lines and a lot more useful.

This makes require('process') always return a reference to the global
process object.

PR-URL: nodejs#206
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member Author

That's a bigger change though (one that you are more than welcome to take on if you want.) Can you LGTM this doc change so I can land it?

@jonathanong
Copy link
Contributor

more docs are always better! 👍

Document the --trace-deprecation flag and the `process` properties that
affect util.deprecate().

Fixes: nodejs#190
PR-URL: nodejs#191
Reviewed-By: Jonathan Ong <me@jongleberry.com>
@bnoordhuis bnoordhuis force-pushed the document-trace-deprecation branch from 2797229 to 8b04161 Compare December 30, 2014 22:49
@bnoordhuis bnoordhuis closed this Dec 30, 2014
@bnoordhuis bnoordhuis deleted the document-trace-deprecation branch December 30, 2014 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants