Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.x backport] util: use blue on non-windows systems for number #19180

Closed
wants to merge 25 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8a8c792
test: http2 client setNextStreamID errors
trivikr Feb 18, 2018
818c2fb
deps: cherry-pick 46c4979e86 from upstream v8
bnoordhuis Feb 21, 2018
bb51e95
src: clean up process.dlopen()
bnoordhuis Feb 22, 2018
1d1a241
src: make process.dlopen() load well-known symbol
bnoordhuis Feb 22, 2018
a243961
build: fix gocvr version used for coverage
mhdawson Mar 2, 2018
bc1038a
module: fix cyclical dynamic import
bmeck Feb 23, 2018
f79d726
doc: add simple example to rename function
punteek Feb 16, 2018
d03929d
doc: new team for bundlers or delivery of Node.js
mhdawson Mar 2, 2018
0ebc7b9
deps: cherry-pick 0bcb1d6f from upstream V8
jakobkummerow Dec 5, 2017
f691777
doc: add introduced_in metadata to _toc.md
Trott Mar 4, 2018
241d1b0
doc: update cc list
BridgeAR Mar 2, 2018
ae2009d
doc: remove tentativeness in pull-requests.md
Trott Mar 4, 2018
4387a2c
doc: remove subsystem from pull request template
Trott Mar 4, 2018
c1b3a15
src: refactor GetPeerCertificate
danbev Mar 2, 2018
8116019
src: use std::unique_ptr for STACK_OF(X509)
bnoordhuis Mar 2, 2018
7fa236b
test: move require http2 to after crypto check
danbev Mar 3, 2018
823f85f
src: #include <stdio.h>" to iculslocs
srl295 Mar 5, 2018
bbeb2a5
perf_hooks: fix timing
TimothyGu Feb 25, 2018
7b4c9a4
test: add more information to assert.strictEqual
ryzokuken Mar 6, 2018
7acf21a
src: handle exceptions in env->SetImmediates
jasnell Jan 26, 2018
d8fef17
src: prevent persistent handle resource leaks
bnoordhuis Feb 21, 2018
52e1830
src: remove unnecessary Reset() calls
bnoordhuis Feb 21, 2018
c5f3d78
src: don't touch js object in Http2Session dtor
bnoordhuis Feb 21, 2018
759b210
http2: no stream destroy while its data is on the wire
addaleax Feb 26, 2018
0d28e9c
util: use blue on non-windows systems for number
devsnek Feb 22, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: remove subsystem from pull request template
Remove request that user provide a list of subsystems in the pull
request template.

* We already ask them to put the subsystems in the first line of the
  commit message.
* The subsystem is usually easy to determine.
* We have a bot that applies subsystem labels on new PRs and it seems to
  do a rather good job. Tools over rules. Let the bot do it.
* The fewer unnecessary things we ask for in the template, the lower the
  barrier to entry.
* Anecdotal, but I have never found it useful to have the person
  submitting the PR list out subsystems in the pull request post.

PR-URL: #19125
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Trott authored and MylesBorins committed Mar 6, 2018

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 4387a2cf802fabc868e306f54791c1d2ebe1ce85
3 changes: 0 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -14,6 +14,3 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)

##### Affected core subsystem(s)
<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->