Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-cluster-worker-disconnect #1919

Closed
wants to merge 1 commit into from
Closed

test: fix test-cluster-worker-disconnect #1919

wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

@bnoordhuis
Copy link
Member

The fact that the test calls process.exit() is a bit suspect because it should be able to terminate naturally once the worker is disconnected... the PR itself doesn't look bad to me but I have a feeling an even more elegant fix is possible.

@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Jun 8, 2015
@santigimeno
test: fix test-cluster-worker-disconnect
096489d 
- Just let the process exit gracefully after the worker is disconnected.
@santigimeno
Copy link
Member Author

@bnoordhuis I think you're right (it fixes #1757 for me). Updated PR with your suggestion

@brendanashworth
Copy link
Contributor

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi_old/840/

@brendanashworth
Copy link
Contributor

CI is happy (Ubuntu died for some reason during linting), LGTM. @bnoordhuis LGTY?

@bnoordhuis
Copy link
Member

LGTM

brendanashworth pushed a commit that referenced this pull request Jun 16, 2015
@santigimeno @brendanashworth
test: fix test-cluster-worker-disconnect
52a822d 
- Just let the process exit gracefully after the worker is disconnected.

Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #1919
Fixes: #1757
@brendanashworth
Copy link
Contributor

Thanks, landed in 52a822d.

@rvagg rvagg mentioned this pull request Jun 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: intermitent failures in test-cluster-worker-disconnect
4 participants
@santigimeno @bnoordhuis @brendanashworth @mscdex