lib: remove unused internal error constructors #19203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Mar 7, 2018
BridgeAR
approved these changes
Mar 7, 2018
|
|
||
| { | ||
| const err = new errors.Error('TEST_ERROR_1', 'test'); | ||
| const err = new errors.codes.TEST_ERROR_1('test'); | ||
| assert(err instanceof Error); |
There was a problem hiding this comment.
When being on it: this is actually not a good test because e.g., TypeError is going to be instanceof Error as well. I would change that to test for the name.
There was a problem hiding this comment.
The error name is checked on the line below this one
|
@targos true, seems like we should consider reworking |
joyeecheung
approved these changes
Mar 7, 2018
jasnell
approved these changes
Mar 7, 2018
|
I pushed two small fixes. |
tniessen
approved these changes
Mar 8, 2018
|
Landed in 7314b17...0eec073 |
targos
added a commit
that referenced
this pull request
Mar 10, 2018
PR-URL: #19203 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
added a commit
that referenced
this pull request
Mar 10, 2018
PR-URL: #19203 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#19203 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#19203 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit removes exports for internal error constructors. Now all internal errors must be thrown using the new system:
throw new errors.codes.MY_ERROR('xxx')instead ofthrow new errors.Error('MY_ERROR', 'xxx').Second commit updates the internal errors documentation following this change.
@BridgeAR I tried to move SystemError to makeNodeErrorWithCode but it's not obvious to me how that could be done because the error code is not fixed, so I left it as is for now.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes