-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: rename regression tests with descriptive file names #19212
Changes from all commits
ae40a78
363aa96
9de9014
18c7841
8bdf66f
3dd9688
edd6a58
8e50585
fb4050f
c8654f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const tmpdir = require('../common/tmpdir'); | ||
|
||
// This test ensures that fs.existsSync doesn't incorrectly return false. | ||
// (especially on Windows) | ||
// https://github.com/nodejs/node-v0.x-archive/issues/3739 | ||
|
||
const assert = require('assert'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: I personally would not mode this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't that in conflict with the canonical test structure? Ref: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#lines-1-3 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is specific to the |
||
let dir = path.resolve(tmpdir.path); | ||
|
||
// Make sure that the tmp directory is clean | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Maybe add a link to the GH issue that this test was named for originally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how I could have missed this, will do.