Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: consistently use bool over int #19238

Closed
wants to merge 1 commit into from
Closed

crypto: consistently use bool over int #19238

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Mar 8, 2018

Just a tiny change to make the use of bool over int consistent.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 8, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Mar 8, 2018
@tniessen
Copy link
Member Author

tniessen commented Mar 8, 2018 •
edited
Loading

Light CI: https://ci.nodejs.org/job/node-test-commit-light/379/
Full CI: https://ci.nodejs.org/job/node-test-pull-request/13603/

@tniessen tniessen mentioned this pull request Mar 9, 2018
Closed
4 tasks
@tniessen
Copy link
Member Author

tniessen commented Mar 9, 2018

Landed in 2b3f46c.

@tniessen tniessen closed this Mar 9, 2018
tniessen added a commit that referenced this pull request Mar 9, 2018
@tniessen
crypto: use bool over int consistently
2b3f46c 
PR-URL: #19238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen tniessen deleted the crypto-update-0-is-false branch March 9, 2018 11:55
targos pushed a commit that referenced this pull request Mar 17, 2018
@tniessen @targos
crypto: use bool over int consistently
1db63e7 
PR-URL: #19238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@tniessen @MylesBorins
crypto: use bool over int consistently
044995e 
PR-URL: #19238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@tniessen @MayaLekova
crypto: use bool over int consistently
11a5872 
PR-URL: nodejs#19238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
@tniessen @jasnell
crypto: use bool over int consistently
468a289 
PR-URL: nodejs#19238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@tniessen @MylesBorins
crypto: use bool over int consistently
4d5cb4c 
Backport-PR-URL: #22380
PR-URL: #19238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @jasnell @lpinca @cjihrig @nodejs-github-bot