Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix some recent nits in assert.md #19284

Closed
wants to merge 1 commit into from
Closed

doc: fix some recent nits in assert.md #19284

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Mar 11, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • add missing bottom reference
  • fix possible typos
  • fix ABC-order in references and sections

@vsemozhetbyt
doc: fix some recent nits in assert.md
abe6058 
* add missing bottom reference
* fix possible typos
* fix ABC-order in references and sections
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2018
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Mar 11, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/249/

@vsemozhetbyt
Copy link
Contributor Author

Landed in 603afe2

@vsemozhetbyt vsemozhetbyt deleted the doc-assert-nits branch March 11, 2018 13:50
vsemozhetbyt added a commit that referenced this pull request Mar 11, 2018
@vsemozhetbyt
doc: fix some recent nits in assert.md
603afe2 
* add missing bottom reference
* fix possible typos
* fix ABC-order in references and sections

PR-URL: #19284
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@vsemozhetbyt @MayaLekova
doc: fix some recent nits in assert.md
19d42fa 
* add missing bottom reference
* fix possible typos
* fix ABC-order in references and sections

PR-URL: nodejs#19284
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vsemozhetbyt @Trott @cjihrig @JungMinu @MylesBorins @BethGriggs @nodejs-github-bot