child_process: define EACCES as a runtime error #19294
Closed
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAccess permission on the target child is currently thrown as an exception. Bring this under the runtime error definition, much like ENOENT and friends.
Fixes: nodejs/help#990
#cat 990.js
#node 990.js ./a.out
ENOENT
#touch a.out
#l a.out
-rw-r--r-- 1 gireesh staff 0 Mar 12 13:41 a.out
#node 990.js ./a.out
while the the definition of runtime errors can be arguable (anything after fork vs. anything after the exec), EACCES belongs to the same group of ENOENT, by all means.
With this fix:
#node 990.js ./a.out
EACCES