Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-cluster-send-handle-large-payload #19311

Closed
wants to merge 1 commit into from
Closed

test: fix test-cluster-send-handle-large-payload #19311

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 13, 2018

test-cluster-send-handle-large-payload is susceptible to failure if it
is competing for resources. Move to sequential directory so it is not
competing with other tests.

Fixes: #14844

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: fix test-cluster-send-handle-large-payload
2403bfb 
test-cluster-send-handle-large-payload is susceptible to failure if it
is competing for resources. Move to `sequential` directory so it is not
competing with other tests.

Fixes: nodejs#14844
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 13, 2018
@Trott
Copy link
Member Author

Trott commented Mar 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13651/

@santigimeno
Copy link
Member

This will make the test less flaky but the freeBSD issue will remain.

@Trott
Copy link
Member Author

Trott commented Mar 13, 2018

This will make the test less flaky but the freeBSD issue will remain.

@santigimeno Stress tests on FreeBSD show that there the test does not fail except when run in parallel (that is, with -j and --repeat set appropriately). In other words, I believe this will in fact fix the issue on FreeBSD (or at least make it vastly less frequent).

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 13, 2018
@santigimeno
Copy link
Member

Yeah, I don't disagree. I meant that the underlying issue will still be there though less visible.

@Trott
Copy link
Member Author

Trott commented Mar 13, 2018

Yeah, I don't disagree. I meant that the underlying issue will still be there though less visible.

Oh, I see. Yes. If we can find a way to trigger the issue reliably without consuming a ton of resources, we could create a known_issues test for it....

@Trott
Copy link
Member Author

Trott commented Mar 15, 2018

Landed in 5e23b65

@Trott Trott closed this Mar 15, 2018
Trott added a commit to Trott/io.js that referenced this pull request Mar 15, 2018
@Trott
test: fix test-cluster-send-handle-large-payload
5e23b65 
test-cluster-send-handle-large-payload is susceptible to failure if it
is competing for resources. Move to `sequential` directory so it is not
competing with other tests.

Fixes: nodejs#14844

PR-URL: nodejs#19311
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this pull request Mar 17, 2018
@Trott @targos
test: fix test-cluster-send-handle-large-payload
03feca3 
test-cluster-send-handle-large-payload is susceptible to failure if it
is competing for resources. Move to `sequential` directory so it is not
competing with other tests.

Fixes: #14844

PR-URL: #19311
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@Trott @MylesBorins
test: fix test-cluster-send-handle-large-payload
9aa5090 
test-cluster-send-handle-large-payload is susceptible to failure if it
is competing for resources. Move to `sequential` directory so it is not
competing with other tests.

Fixes: #14844

PR-URL: #19311
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@mhdawson mhdawson mentioned this pull request Jun 7, 2018
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Jul 31, 2018
@Trott @MylesBorins
test: fix test-cluster-send-handle-large-payload
093b777 
test-cluster-send-handle-large-payload is susceptible to failure if it
is competing for resources. Move to `sequential` directory so it is not
competing with other tests.

Fixes: #14844

PR-URL: #19311
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Trott @rvagg
test: fix test-cluster-send-handle-large-payload
0517cd8 
test-cluster-send-handle-large-payload is susceptible to failure if it
is competing for resources. Move to `sequential` directory so it is not
competing with other tests.

Fixes: #14844

PR-URL: #19311
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
@Trott Trott deleted the json-error branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate parallel/test-cluster-send-handle-large-payload failure on FreeBSD
5 participants
@Trott @santigimeno @danbev @MylesBorins @nodejs-github-bot