Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix minor issues in async_hooks.md #19313

Closed
wants to merge 1 commit into from
Closed

doc: fix minor issues in async_hooks.md #19313

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 13, 2018

  • easily -> easy
  • was -> is
  • add a missing comma
Checklist

@Trott
doc: fix minor issues in async_hooks.md
e216256 
* easily -> easy
* was -> is
* add a missing comma
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Mar 13, 2018
@Trott
Copy link
Member Author

Trott commented Mar 13, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/253/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 13, 2018
@Trott
Copy link
Member Author

Trott commented Mar 15, 2018

Landed in e5e0f9f

@Trott Trott closed this Mar 15, 2018
Trott added a commit to Trott/io.js that referenced this pull request Mar 15, 2018
@Trott
doc: fix minor issues in async_hooks.md
e5e0f9f 
* easily -> easy
* was -> is
* add a missing comma

PR-URL: nodejs#19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 17, 2018
@Trott @targos
doc: fix minor issues in async_hooks.md
fd47342 
* easily -> easy
* was -> is
* add a missing comma

PR-URL: #19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@Trott @MylesBorins
doc: fix minor issues in async_hooks.md
5a56327 
* easily -> easy
* was -> is
* add a missing comma

PR-URL: #19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@Trott @BethGriggs
doc: fix minor issues in async_hooks.md
9446bb6 
* easily -> easy
* was -> is
* add a missing comma

PR-URL: #19313
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
@Trott Trott deleted the quick-fixes branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @lpinca @cjihrig @vsemozhetbyt @nodejs-github-bot