Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v9.x backport) crypto: allow passing null as IV unless required #19347

Closed
wants to merge 0 commits into from
Closed

(v9.x backport) crypto: allow passing null as IV unless required #19347

wants to merge 0 commits into from

Conversation

tniessen
Copy link
Member

Manual backport of #18644 to v9.x.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. v9.x labels Mar 14, 2018
@tniessen tniessen mentioned this pull request Mar 14, 2018
Closed
4 tasks
@MylesBorins MylesBorins force-pushed the v9.x-staging branch 2 times, most recently from 8d8f3fc to d457b9d Compare March 20, 2018 11:54
@MylesBorins
Copy link
Contributor

landed in d457b9d767

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@tniessen @MylesBorins
crypto: allow passing null as IV unless required
03c321a 
Backport-PR-URL: #19347
PR-URL: #18644
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@tniessen @MylesBorins
crypto: allow passing null as IV unless required
c1c6253 
Backport-PR-URL: #19347
PR-URL: #18644
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@tniessen @MylesBorins
crypto: allow passing null as IV unless required
9790c09 
Backport-PR-URL: #19347
PR-URL: #18644
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@tniessen @MylesBorins
crypto: allow passing null as IV unless required
7be8f16 
Backport-PR-URL: #19347
PR-URL: #18644
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@tniessen @MylesBorins
crypto: allow passing null as IV unless required
802e26b 
Backport-PR-URL: #19347
PR-URL: #18644
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@tniessen @MylesBorins
crypto: allow passing null as IV unless required
fc34f5c 
Backport-PR-URL: #19347
PR-URL: #18644
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tniessen @MylesBorins @nodejs-github-bot