[v6.x backport] test: make common.mustNotCall show file:linenumber #19355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test fails via
common.mustNotCall
it is sometimes hard todetermine exactly what was called. This modification stores the
caller's file and line number by using the V8 Error API to capture
a stack at the time
common.mustNotCall()
is called. In the eventof failure, this information is printed.
This change also exposes a new function in test/common,
getCallSite()
which accepts a
function
and returns aString
with the file name andline number for the function.
Ref: #17257
PR-URL: #17257
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Sakthipriyan Vairamani thechargingvolcano@gmail.com
Reviewed-By: Khaidi Chu i@2333.moe
NOTE: This commit also includes
common.canCreateSymlink()
, for which the documentation has been backported, but not the implementation. If desired, this can be removed - it came along for the ride when cherry-picking.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes