Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs,net: emitting ready event for fs streams and network sockets in addition… #19408

Closed
wants to merge 5 commits into from

Commits on Mar 17, 2018

  1. fs,net: emitting ready for fs streams and network sockets in addition…

    … to the event names they currently use.
    
    Currently, various internal streams have different events that indicate that the
    underlying resource has successfully been established. This commit adds ready event
    for fs and net sockets to standardize on emitting ready for all of these streams.
    
    Fixes: nodejs#19304
    sameer-coder committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    204d89d View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2018

  1. fs,net: removed file descriptor for ready event and updated test case

    removed file descriptor for ready event in fs streams and updated test case
    to check only for ready event.
    
    Fixes: nodejs#19304
    sameer-coder committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    01ee0db View commit details
    Browse the repository at this point in the history
  2. fs,net: removed file descriptor for ready event (writestream)

    removed file descriptor for ready event in fs streams and updated test case
    to check only for ready event.
    
    Fixes: nodejs#19304
    sameer-coder committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    e93c869 View commit details
    Browse the repository at this point in the history
  3. fs,net: updated test case to check for ready event on writestream

    updated test case updated test case to check for ready event
    on writestream
    
    Fixes: nodejs#19304
    sameer-coder committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    0778b58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    008474a View commit details
    Browse the repository at this point in the history