src: ensure that SetImmediate()s have HandleScopes
#19470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `unique_ptr`s and use the resulting simplification to reduce indentation in these functions.
Make sure that all native `SetImmediate()` functions have `HandleScope`s if they create handles.
nodejs-github-bot
added
c++
cjihrig
approved these changes
Mar 20, 2018
addaleax
added
the
author ready
TimothyGu
approved these changes
Mar 20, 2018
jasnell
approved these changes
Mar 20, 2018
tniessen
approved these changes
Mar 20, 2018
|
New CI, to be sure: https://ci.nodejs.org/job/node-test-commit/17120/ |
addaleax
added a commit
that referenced
this pull request
Mar 25, 2018
Use `unique_ptr`s and use the resulting simplification to reduce indentation in these functions. PR-URL: #19470 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
added a commit
that referenced
this pull request
Mar 25, 2018
Make sure that all native `SetImmediate()` functions have `HandleScope`s if they create handles. PR-URL: #19470 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
added
dont-land-on-v9.x
and removed
author ready
addaleax
added a commit
that referenced
this pull request
Jun 29, 2018
Use `unique_ptr`s and use the resulting simplification to reduce indentation in these functions. PR-URL: #19470 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
Use `unique_ptr`s and use the resulting simplification to reduce indentation in these functions. PR-URL: #19470 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: simplify http2 perf tracking code
Use
unique_ptrs and use the resulting simplification toreduce indentation in these functions.
src: ensure that
SetImmediate()s haveHandleScopesMake sure that all native
SetImmediate()functions haveHandleScopes if they create handles.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesCI: https://ci.nodejs.org/job/node-test-commit/17015/