net: allow IPC servers be accessible by all #19472

bzoz · 2018-03-20T10:25:38Z

Adds mappings to uv_pipe_chmod call by adding two new options to listen call. This allows the IPC server pipe to be made readable or writable by all users.

Fixes: #19154

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

bzoz · 2018-03-20T10:26:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/13758/

vsemozhetbyt · 2018-03-20T10:33:20Z

doc/api/net.md

@@ -250,6 +250,10 @@ added: v0.11.14
  * `backlog` {number} Common parameter of [`server.listen()`][]
    functions.
  * `exclusive` {boolean} **Default:** `false`
+  * `readable_all` {boolean} For IPC servers makes the pipe readable
+    for all users. ***Default:** `false`


Nit: *** -> **

vsemozhetbyt · 2018-03-20T10:33:34Z

doc/api/net.md

+  * `readable_all` {boolean} For IPC servers makes the pipe readable
+    for all users. ***Default:** `false`
+  * `writable_all` {boolean} For IPC servers makes the pipe writable
+    for all users. ***Default:** `false`


Nit: *** -> **

cjihrig · 2018-03-21T03:37:23Z

doc/api/net.md

@@ -250,6 +250,10 @@ added: v0.11.14
  * `backlog` {number} Common parameter of [`server.listen()`][]
    functions.
  * `exclusive` {boolean} **Default:** `false`
+  * `readable_all` {boolean} For IPC servers makes the pipe readable


These options should be camelCase.

cjihrig · 2018-03-21T03:39:35Z

lib/net.js

@@ -1524,6 +1524,13 @@ Server.prototype.listen = function(...args) {
    backlog = options.backlog || backlogFromArgs;
    listenInCluster(this, pipeName, -1, -1,
                    backlog, undefined, options.exclusive);
+    let mode = 0;
+    if (!!options.readable_all)


Since these are expected to be booleans, you could do options.readableAll === true.

bzoz · 2018-03-21T13:15:56Z

Updated, PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/13808/

bzoz · 2018-03-29T08:36:39Z

ping

CI failures are unrelated.

vsemozhetbyt · 2018-03-29T08:52:07Z

As per "Who to cc...", cc @bnoordhuis, @indutny, @nodejs/streams

bnoordhuis

Pinging @santigimeno since he also reviewed the libuv pull request.

bnoordhuis · 2018-03-29T10:08:33Z

doc/api/net.md

+  * `readableAll` {boolean} For IPC servers makes the pipe readable
+    for all users. **Default:** `false`
+  * `writableAll` {boolean} For IPC servers makes the pipe writable
+    for all users. **Default:** `false`


Should explain why you would want to do that, not just how.

bnoordhuis · 2018-03-29T10:10:02Z

lib/net.js

+    let mode = 0;
+    if (options.readableAll === true)
+      mode |= PipeConstants.READABLE_ALL;
+    if (options.writableAll === true)


Just curious, what is the reason you went for strict true-ness instead of truthiness?

bnoordhuis · 2018-03-29T10:10:59Z

lib/net.js

+    if (options.writableAll === true)
+      mode |= PipeConstants.WRITABLE_ALL;
+    if (mode !== 0)
+      this._handle.fchmod(mode);


Check the return value.

santigimeno

Changes LGTM. A couple of comments:

I guess it's not easy testing this functionality on every platform but we could add tests that at least make sure that the changes don't break anything. We could even use fs.stat to check the mode of the pipe path on unices?
We should merge pipe: fixed uv_pipe_chmod for OSX Darwin libuv/libuv#1635 soon to fix uv_pipe_chmod on OS X.

BridgeAR · 2018-04-16T03:20:50Z

@bzoz seems like the tests are failing.

bzoz · 2018-04-16T16:25:10Z

Linux failures seem unrelated, re-running the CI just to make sure: https://ci.nodejs.org/job/node-test-pull-request/14333/

bzoz · 2018-04-17T07:53:41Z

Failures look unrelated, PTAL

bzoz · 2018-04-19T10:28:02Z

Ping?

BridgeAR · 2018-04-28T14:51:54Z

It would be good to get some further LGs for this. Ping @nodejs/http @nodejs/http2 @nodejs/streams

addaleax · 2018-05-05T11:59:16Z

src/pipe_wrap.cc

+void PipeWrap::Fchmod(const v8::FunctionCallbackInfo<v8::Value>& args) {
+  PipeWrap* wrap;
+  ASSIGN_OR_RETURN_UNWRAP(&wrap, args.Holder());
+  int mode = args[0]->Int32Value();


Could you use the overload that takes a context argument, or (even better imo) write this as

CHECK(args[0]->IsInt32()); int mode = args[0].As<Int32>()->Value();

?

addaleax · 2018-05-05T11:59:50Z

src/pipe_wrap.h

+  enum PipeChmod {
+    READABLE_ALL = UV_READABLE,
+    WRITABLE_ALL = UV_WRITABLE
+  };


Is there any reason not to expose the libuv names directly? Makes things a bit more grepable :)

addaleax · 2018-05-14T17:00:12Z

Gentle ping in the direction of @bzoz :)

Adds mappings to uv_pipe_chmod call by adding two new options to listen call. This allows the IPC server pipe to be made readable or writable by all users. Fixes: nodejs#19154

bzoz · 2018-05-17T11:45:18Z

Updated (and rebased), PTAL

bzoz · 2018-05-21T14:42:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/15000/

bzoz · 2018-05-23T16:01:35Z

Failures are unrelated, If no one objects I'll land this tomorrow.

bzoz · 2018-05-24T09:07:07Z

Landed in 531b4be

Adds mappings to uv_pipe_chmod call by adding two new options to listen call. This allows the IPC server pipe to be made readable or writable by all users. Fixes: #19154 PR-URL: #19472 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos · 2018-05-25T12:02:37Z

Marking semver-minor because of the two new options.

Adds mappings to uv_pipe_chmod call by adding two new options to listen call. This allows the IPC server pipe to be made readable or writable by all users. Fixes: #19154 PR-URL: #19472 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable Changes: * **deps**: - upgrade npm to 6.1.0 (Rebecca Turner) #20190 * **fs**: - fix reads with pos \> 4GB (Mathias Buus) #21003 * **net**: - new option to allow IPC servers to be readable and writable by all users (Bartosz Sosnowski) #19472 * **stream**: - fix removeAllListeners() for Stream.Readable to work as expected when no arguments are passed (Kael Zhang) #20924 * **Added new collaborators** - John-David Dalton (https://github.com/jdalton) PR-URL: #21011

jeroenvollenbrock · 2019-05-14T14:51:43Z

Just out of curiosity, is there any chance of this receiving a backport to Node 8 even though it already entered maintenance state? It seems like a very minor task as the proper libuv version is already present, and since there is no easy workaround for the lack of this functionality on node 8, especially on windows, I'd be happy to give it a shot.
@addaleax @MylesBorins

MylesBorins · 2019-05-14T15:49:08Z

@jeroenvollenbrock I do not believe this will be able to land on 8.x. It is in maintenance mode and as such we don't do regular semver-minors. We did recently do one, but the only minor changes that landed were updates to napi

/cc @nodejs/lts

jeroenvollenbrock · 2019-05-14T17:03:08Z

I understand and very well respect the policy of not backporting semver-minor changes. I do think however it might be a good idea to make it a bit more clear in the documentation that readableAll and writableAll are node 10+ options in case a backport is definitely not possible. The docs currently make it seem like these two options have been around since Node v0.11.14. I actually only found out they weren't after debugging EACCESS errors, and manually compared v8 docs with the v10 docs.

bzoz added the net Issues and PRs related to the net subsystem. label Mar 20, 2018

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 20, 2018

vsemozhetbyt reviewed Mar 20, 2018

View reviewed changes

cjihrig reviewed Mar 21, 2018

View reviewed changes

bnoordhuis reviewed Mar 29, 2018

View reviewed changes

santigimeno approved these changes Mar 29, 2018

View reviewed changes

BridgeAR added the wip Issues and PRs that are still a work in progress. label Apr 16, 2018

bzoz removed the wip Issues and PRs that are still a work in progress. label Apr 17, 2018

santigimeno approved these changes Apr 19, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2018

addaleax approved these changes May 5, 2018

View reviewed changes

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2018

net: allow IPC servers be accessible by all

6d8b6dc

Adds mappings to uv_pipe_chmod call by adding two new options to listen call. This allows the IPC server pipe to be made readable or writable by all users. Fixes: nodejs#19154

bzoz force-pushed the bartek-add-pipe-chmod branch from 76f7e9e to 6d8b6dc Compare May 17, 2018 11:45

bzoz closed this May 24, 2018

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label May 25, 2018

MylesBorins mentioned this pull request May 29, 2018

v10.3.0 proposal #21011

Merged

jugglinmike mentioned this pull request Dec 13, 2021

fix: exit at-driver with error if run as admin w3c/aria-at-automation-driver#4

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: allow IPC servers be accessible by all #19472

net: allow IPC servers be accessible by all #19472

bzoz commented Mar 20, 2018

bzoz commented Mar 20, 2018

vsemozhetbyt Mar 20, 2018

vsemozhetbyt Mar 20, 2018

cjihrig Mar 21, 2018

cjihrig Mar 21, 2018

bzoz commented Mar 21, 2018

bzoz commented Mar 29, 2018

vsemozhetbyt commented Mar 29, 2018

bnoordhuis left a comment

bnoordhuis Mar 29, 2018

bnoordhuis Mar 29, 2018

bnoordhuis Mar 29, 2018

santigimeno left a comment

BridgeAR commented Apr 16, 2018

bzoz commented Apr 16, 2018

bzoz commented Apr 17, 2018

bzoz commented Apr 19, 2018

BridgeAR commented Apr 28, 2018

addaleax May 5, 2018

addaleax May 5, 2018

addaleax commented May 14, 2018

bzoz commented May 17, 2018

bzoz commented May 21, 2018

bzoz commented May 23, 2018

bzoz commented May 24, 2018

targos commented May 25, 2018

jeroenvollenbrock commented May 14, 2019

MylesBorins commented May 14, 2019

jeroenvollenbrock commented May 14, 2019

net: allow IPC servers be accessible by all #19472

net: allow IPC servers be accessible by all #19472

Conversation

bzoz commented Mar 20, 2018

Checklist

bzoz commented Mar 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bzoz commented Mar 21, 2018

bzoz commented Mar 29, 2018

vsemozhetbyt commented Mar 29, 2018

bnoordhuis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

santigimeno left a comment

Choose a reason for hiding this comment

BridgeAR commented Apr 16, 2018

bzoz commented Apr 16, 2018

bzoz commented Apr 17, 2018

bzoz commented Apr 19, 2018

BridgeAR commented Apr 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addaleax commented May 14, 2018

bzoz commented May 17, 2018

bzoz commented May 21, 2018

bzoz commented May 23, 2018

bzoz commented May 24, 2018

targos commented May 25, 2018

jeroenvollenbrock commented May 14, 2019

MylesBorins commented May 14, 2019

jeroenvollenbrock commented May 14, 2019