Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: backport 596d55a from upstream #19477

Closed
wants to merge 1 commit into from

Commits on Mar 20, 2018

  1. deps: V8: backport 596d55a from upstream

    Did not remove ActivationsFinder from `src/runtime/runtime-compiler.cc`
    as in the original commit as the Class is still being used prior to
    f0acede landing
    
    Original Commit Message:
    
        Deoptimization and multithreading.
    
        When using Lockers and Unlockers it is possible to create a
        scenario where multiple threads point to the same optimized
        code object. When that happens, if one of the threads triggers
        deoptimization, then the stack replacement needs to happen in
        the stacks of all threads.
        With this CL, the deoptimizer visits all threads to do so.
        The CL also adds three tests where V8 used to crash due to this
        issue.
    
        Bug: v8:6563
        Change-Id: I74e9af472d4833aa8d13e579df45133791f6a503
        Reviewed-on: https://chromium-review.googlesource.com/670783
        Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
        Commit-Queue: Juliana Patricia Vicente Franco <jupvfranco@google.com>
        Cr-Commit-Position: refs/heads/master@{nodejs#48060}
    
    Refs: v8/v8@596d55a
    Refs: v8/v8@f0acede
    Fixes: nodejs#19274
    MylesBorins committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    f2a75d1 View commit details
    Browse the repository at this point in the history