Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x] doc: fix deprecation removed by mistake #19482

Closed
wants to merge 1 commit into from
Closed

[v9.x] doc: fix deprecation removed by mistake #19482

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 20, 2018

In bae5de1,
a deprecation (DEP0089) was added to the docs and another one (DEP0098)
was removed by mistake. This commit restores it.

Fixes #19428 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@targos
doc: fix deprecation removed by mistake
67f20d5 
In nodejs@bae5de1,
a deprecation (DEP0089) was added to the docs and another one (DEP0098)
was removed by mistake. This commit restores it.
@targos targos added doc Issues and PRs related to the documentations. v9.x fast-track PRs that do not need to wait for 48 hours to land. labels Mar 20, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v9.x labels Mar 20, 2018
@targos targos changed the title doc: fix deprecation removed by mistake [v9.x] doc: fix deprecation removed by mistake Mar 20, 2018
@targos
Copy link
Member Author

targos commented Mar 20, 2018

@BridgeAR @MylesBorins

@BridgeAR
Copy link
Member

@targos thanks for fixing this. Seems like I removed that in the backport by mistake.

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@targos @MylesBorins
doc: fix deprecation removed by mistake
a4c28d7 
In bae5de1,
a deprecation (DEP0089) was added to the docs and another one (DEP0098)
was removed by mistake. This commit restores it.

PR-URL: #19482
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor

landed in a4c28d7

@targos targos mentioned this pull request Mar 21, 2018
Merged
@targos targos deleted the fix-doc-v9.x branch October 17, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @BridgeAR @MylesBorins @cjihrig @nodejs-github-bot