Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix paragraph order in stream.md #19501

Closed
wants to merge 1 commit into from
Closed

doc: fix paragraph order in stream.md #19501

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Place writable.destroy(), readable.destroy(), and readable.read() in the proper ABC order.

@vsemozhetbyt
doc: fix paragraph order in stream.md
b6d9630 
Place `writable.destroy()`, `readable.destroy()`,
and `readable.read()` in the proper ABC order.
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 21, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Mar 21, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Mar 21, 2018 •
edited
Loading

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/284/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2018
vsemozhetbyt added a commit that referenced this pull request Mar 21, 2018
@vsemozhetbyt
doc: fix paragraph order in stream.md
3662934 
Place `writable.destroy()`, `readable.destroy()`,
and `readable.read()` in the proper ABC order.

PR-URL: #19501
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 3662934

@vsemozhetbyt vsemozhetbyt deleted the doc-stream-order branch March 21, 2018 02:54
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vsemozhetbyt @Trott @cjihrig @MylesBorins @tniessen @nodejs-github-bot