Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make metadata parsing less permissive #19512

Closed
wants to merge 2 commits into from
Closed

tools: make metadata parsing less permissive #19512

wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

This change slightly shortens extractAndParseYAML and removes support for parsing Added: and Deprecated: in favor of the lowercase variants. We are consistent about that in our API docs, so the tooling should be consistent as well.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 21, 2018
@tniessen
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13832/

@tniessen
Copy link
Member Author

Re-running linuxone: https://ci.nodejs.org/job/node-test-commit-linuxone/13945/

@tniessen
Copy link
Member Author

Landed in 5b9f8e1, 337e040.

@tniessen tniessen closed this Mar 25, 2018
tniessen added a commit that referenced this pull request Mar 25, 2018
@tniessen
tools: make metadata parsing less permissive
5b9f8e1 
PR-URL: #19512
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen added a commit that referenced this pull request Mar 25, 2018
@tniessen
tools: shorten metadata parsing
337e040 
PR-URL: #19512
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2018
@tniessen @targos
tools: make metadata parsing less permissive
0db7b8c 
PR-URL: #19512
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2018
@tniessen @targos
tools: shorten metadata parsing
ab561c0 
PR-URL: #19512
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@tniessen @MylesBorins
tools: make metadata parsing less permissive
aa3be00 
PR-URL: #19512
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@tniessen @MylesBorins
tools: shorten metadata parsing
11b8d47 
PR-URL: #19512
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @jasnell @lpinca @TimothyGu @MylesBorins @nodejs-github-bot