-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: rename js source to lower snake_case #19556
Conversation
in https://github.com/nodejs/node/tree/master/lib/internal/modules/esm everything is named in that style, i suppose they should also be renamed? |
It is named like this because it exports a single class. |
I did notice this and that is why I brought it up. Do we want to keep it like this or should we rename all JavaScript source files to lowercase? (I'd prefer to rename) |
i've had enough trouble with caseless filesystems to wholeheartedly recommend keeping everything as snake_case |
7465b10
to
ec7fed4
Compare
node-test-commit-linuxone failure looks unrelatedBuilding addon /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/addons-napi/test_function/
if [ -x /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/./node ] && [ -e /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/./node ]; then /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/./node tools/doc/generate.js --format=json doc/api/cluster.md > out/doc/api/cluster.json; elif [ -x `which node` ] && [ -e `which node` ] && [ `which node` ]; then `which node` tools/doc/generate.js --format=json doc/api/cluster.md > out/doc/api/cluster.json; else echo "No available node, cannot run \"node tools/doc/generate.js --format=json doc/api/cluster.md > out/doc/api/cluster.json\""; exit 1; fi;
SOLINK_MODULE(target) Release/obj.target/binding.node
COPY Release/binding.node
make[2]: Leaving directory `/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/addons/hello-world/build'
make[2]: write error
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 1
gyp ERR! stack at ChildProcess.onExit (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/deps/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stackmake[1]: gyp info it worked if it ends with ok |
This commit renames all JavaScript source files in lib/internal/modules to lower snake_case.
ec7fed4
to
da58002
Compare
This code looks good to land |
Landed in f2b1079. |
This commit renames all JavaScript source files in lib to lower snake_case. PR-URL: #19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Should this be backported to |
This commit renames all JavaScript source files in lib to lower snake_case. PR-URL: nodejs#19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit renames all JavaScript source files in lib to lower snake_case. PR-URL: nodejs#19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit renames all JavaScript source files in lib to lower snake_case. Backport-PR-URL: #19969 PR-URL: #19556 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit renames all JavaScript source files in lib to lower snake_case.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes