src: rename req_wrap with -async/-sync suffix #19628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
joyeecheung
approved these changes
Mar 27, 2018
| FSReqBase* req_wrap = GetReqWrap(env, args[2]); | ||
| if (req_wrap != nullptr) { // access(path, mode, req) | ||
| AsyncCall(env, req_wrap, args, "access", UTF8, AfterNoArgs, | ||
| FSReqBase* req_wrap_async = GetReqWrap(env, args[2]); |
There was a problem hiding this comment.
Just realized it would be even easier to understand if FSReqBase is FSReqWrapAsync..LGTM with or without that though.
There was a problem hiding this comment.
Sorry about the late reply on this. I don't think that is possible with as GetReqWrap can also return FSReqPromise.
jasnell
approved these changes
Mar 28, 2018
This commit renames the req_wrap variable to use an -async/-sync suffix to avoid cases where the variables were being shadowed. Refs: nodejs#19614
danbev
force-pushed
the
rename_req_wrap_to_async_and_sync
branch
from
3009260 to
c195864
Compare
node-test-commit-linuxone failure looks unrelatedmake[2]: write error
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 1
gyp ERR! Process leaked file descriptors. See https://jenkins.io/redirect/troubleshooting/process-leaked-file-descriptors for more informationnode-test-arm-fanned failure looks unrelated06:23:58 not ok 40 parallel/test-cluster-master-kill
06:23:58 ---
06:23:58 duration_ms: 360.112
06:23:58 severity: fail
06:23:58 stack: |-
06:23:58 timeout
06:23:58 ... |
|
Landed in ed86cc5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the req_wrap variable to use an -async/-sync
suffix to avoid cases where the variables were being shadowed.
Refs: #19614
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes