Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x backport] src: free memory before re-setting URLHost value #19639

Closed
wants to merge 1 commit into from
Closed

[v6.x backport] src: free memory before re-setting URLHost value #19639

wants to merge 1 commit into from

Conversation

prog1dev
Copy link
Contributor

@prog1dev prog1dev commented Mar 27, 2018 •
edited
Loading

Original pr #18357

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@MylesBorins

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 27, 2018
@prog1dev
Copy link
Contributor Author

prog1dev commented Mar 29, 2018 •
edited
Loading

Something went wrong 😄
+848 −38,000

@TimothyGu
Copy link
Member

@prog1dev It’s probably because there have been force-pushes to the v8.x-staging branch. A careful rebase should fix the problem.

@prog1dev
src: free memory before re-setting URLHost value
af2c41e 
Fixes: nodejs#18302

PR-URL: nodejs#18357
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/14231/

MylesBorins pushed a commit that referenced this pull request Apr 13, 2018
@prog1dev @MylesBorins
src: free memory before re-setting URLHost value
0ca2dad 
Fixes: #18302

Backport-PR-URL: #19639
PR-URL: #18357
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins
Copy link
Contributor

landed in 0ca2dad

@prog1dev prog1dev deleted the backport-18357-to-v6.x branch April 13, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prog1dev @TimothyGu @MylesBorins @nodejs-github-bot