Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: remove MISSING_ARGS error code #19677

Closed
wants to merge 1 commit into from
Closed

vm: remove MISSING_ARGS error code #19677

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

The documentation states:

This is only used for strict compliance with the API specification
(which in some cases may accept func(undefined) but not func()). In
most native Node.js APIs, func(undefined) and func() are treated
identically, and the ERR_INVALID_ARG_TYPE error code may be used
instead.

Refs: #19268 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@TimothyGu
vm: remove MISSING_ARGS error code
7118e91 
The documentation states:

> This is only used for strict compliance with the API specification
> (which in some cases may accept func(undefined) but not func()). In
> most native Node.js APIs, func(undefined) and func() are treated
> identically, and the ERR_INVALID_ARG_TYPE error code may be used
> instead.

Refs: nodejs#19268 (comment)
@nodejs-github-bot nodejs-github-bot added the vm Issues and PRs related to the vm subsystem. label Mar 29, 2018
@TimothyGu TimothyGu requested a review from joyeecheung March 29, 2018 19:09
@TimothyGu
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13928/

targos
targos approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I am already doing it here: #19398

@TimothyGu
Copy link
Member Author

Let's defer to your PR then :)

@TimothyGu TimothyGu closed this Mar 29, 2018
@TimothyGu TimothyGu deleted the vm-fixup branch March 29, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimothyGu @targos @nodejs-github-bot