Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-cluster-send-handle-twice #19700

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-cluster-send-handle-twice #19700

wants to merge 1 commit into from

Commits on Mar 30, 2018

  1. test: fix flaky test-cluster-send-handle-twice 

    Use `common.mustCall()` to make sure connection callback runs exactly
once.

Use `connect` event instead of `setTimeout` to avoid test failing if
timer runs before client is connected.

Remove `cluster.worker.disconnect()` after `assert.fail()`. It is
unreachable code that is unnecessary.
    @Trott
    Trott committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    f97c2b0 View commit details
    Browse the repository at this point in the history